-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 New UI Settings #19333
Add 3 New UI Settings #19333
Conversation
3509bb0
to
8fc17ea
Compare
- Add UI to set `machine_start_gcode_first` so that no gcode is adding infront of the start_gcode. - Add float input box to set `machine_extruder_change_duration` which added proper extruder change times to the estimated print time. - Add textbox to set `machine_extruder_prestart_code` to add gcodes that will run pre extruder change, things like heat up so we are at change before with pick up the next extruder.
Added a small fix to apply variable expansion to the extruder prestart code |
Just having a hard time applying defaults to the Stealthchanger definitions and isn't working, neither setting gets applied on create new, did I miss an other spot to be able to apply these by default on new printer creation? Any help here would be appreciated. |
Updated for the latest code and tested, still I can not set these values when adding a new printer, but the options themselves to work. I can not figure out why they won't preset with a new printer though. |
Update, the first extruder gets the proper defaults values, all extruders after that do need get the defaults from base, not able to figure out why it's not propagating to each extruder :\ Also the default value for start_gcode_first isn't auto checked on adding a new printer. Am I suppose to version up the definitions so they auto apply? but everything else is tested and working now. |
For future reference -- we've had problems with the size of these fields on the minimum required screen resolution, so we could fix that by making them a little higher -- I fear these changes will make that problem appear again for the leftmost two fields. |
oh what is the min I'll resize to that in the future, I didn't find any documentation on that so I just used the default size it shows up in. |
Description
machine_start_gcode_first
so that no gcode is adding infront of the start_gcode.machine_extruder_change_duration
which added proper extruder change times to the estimated print time.machine_extruder_prestart_code
to add gcodes that will run pre extruder change, things like heat up so we are at change before with pick up the next extruder.Required for Ultimaker/CuraEngine#2114
Type of change
How Has This Been Tested?
UI has been tested, Engine has not yet.
Test Configuration:
Checklist: