Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 New UI Settings #19333

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Add 3 New UI Settings #19333

merged 7 commits into from
Oct 10, 2024

Conversation

TheSin-
Copy link
Contributor

@TheSin- TheSin- commented Jul 6, 2024

Description

  • Add UI to set machine_start_gcode_first so that no gcode is adding infront of the start_gcode.
  • Add float input box to set machine_extruder_change_duration which added proper extruder change times to the estimated print time.
  • Add textbox to set machine_extruder_prestart_code to add gcodes that will run pre extruder change, things like heat up so we are at change before with pick up the next extruder.

Required for Ultimaker/CuraEngine#2114

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

UI has been tested, Engine has not yet.

machine_settings
Extruder_settings

Test Configuration:

  • Operating System: MacOS

Checklist:

resources/definitions/fdmprinter.def.json Outdated Show resolved Hide resolved
resources/definitions/fdmextruder.def.json Outdated Show resolved Hide resolved
@TheSin- TheSin- force-pushed the main branch 2 times, most recently from 3509bb0 to 8fc17ea Compare August 7, 2024 21:02
- Add UI to set `machine_start_gcode_first` so that no gcode is adding infront of the start_gcode.
- Add float input box to set `machine_extruder_change_duration` which added proper extruder change times to the estimated print time.
- Add textbox to set `machine_extruder_prestart_code` to add gcodes that will run pre extruder change, things like heat up so we are at change before with pick up the next extruder.
@TheSin-
Copy link
Contributor Author

TheSin- commented Aug 10, 2024

Added a small fix to apply variable expansion to the extruder prestart code

@TheSin-
Copy link
Contributor Author

TheSin- commented Aug 10, 2024

Just having a hard time applying defaults to the Stealthchanger definitions

https://github.com/Ultimaker/Cura/pull/19333/files#diff-332a6d8c562113aa0e0654240c5a5602d8da4f81b58d00364f9e8cc4ce262656

and

https://github.com/Ultimaker/Cura/pull/19333/files#diff-6b841fe2c6a7e75eb9924ba3abc210631e2ff62ba6a8fcc0702113874496f7e1

isn't working, neither setting gets applied on create new, did I miss an other spot to be able to apply these by default on new printer creation? Any help here would be appreciated.

@TheSin-
Copy link
Contributor Author

TheSin- commented Aug 10, 2024

Updated for the latest code and tested, still I can not set these values when adding a new printer, but the options themselves to work. I can not figure out why they won't preset with a new printer though.

@TheSin-
Copy link
Contributor Author

TheSin- commented Aug 27, 2024

Update, the first extruder gets the proper defaults values, all extruders after that do need get the defaults from base, not able to figure out why it's not propagating to each extruder :\

Also the default value for start_gcode_first isn't auto checked on adding a new printer. Am I suppose to version up the definitions so they auto apply?

but everything else is tested and working now.

@nallath nallath merged commit aaff84c into Ultimaker:main Oct 10, 2024
@rburema
Copy link
Member

rburema commented Nov 26, 2024

For future reference -- we've had problems with the size of these fields on the minimum required screen resolution, so we could fix that by making them a little higher -- I fear these changes will make that problem appear again for the leftmost two fields.

@TheSin-
Copy link
Contributor Author

TheSin- commented Nov 26, 2024

oh what is the min I'll resize to that in the future, I didn't find any documentation on that so I just used the default size it shows up in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants