[PP-502] Method profile corrections #19358

alanbjorklund · 2024-07-10T21:20:26Z

Description

improves print quality for various materials
prevents slice failures for PLA self support

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Printer definition file(s)
Translations

How Has This Been Tested?

I copied the extruder, definition, variant & quality files into the Beta 5.8 build and checked values in the UI. I also sliced 44 files (1 per Method X & Method XL configuration) that I will be printing over the next few days.

Test A
Test B

Test Configuration:

Operating System:

Ventura 13.6.6

Checklist:

My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
I have read the Contribution guide
I have commented my code, particularly in hard-to-understand areas
I have uploaded any files required to test this change

This is necessary because the parent definition of the settings has changed

Change default_value to value

PP-502

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json

resources/definitions/ultimaker_method.def.json

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg

CURA-12009

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json

resources/quality/ultimaker_method/um_method_1a_um-pla-175_0.2mm.inst.cfg

resources/quality/ultimaker_method/um_method_1c_um-pla-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-pla-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_labs_um-abscf-175_0.2mm.inst.cfg

resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg

nallath · 2024-07-11T11:10:59Z

resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg

 raft_interface_speed = 15
-raft_interface_z_offset = -0.05
+raft_interface_z_offset = =-0.1 if raft_base_thickness == 0.5 else -0.05


Why the exact comparison with 0.5? Seems like a bit of a weird thing, shouldn't it be someting like lower than 0.5?

Paul suggested tying this raft interface logic to a specific raft base value rather than saying "if PVA is paired with N12CF". Although, your comment here made me double check the N12CF file for the raft base height and it was actually set to 0.4 (this is a mistake). So I am going to update this value in the N12CF file to reflect 0.5 instead of 0.4. If there's a better way to reference a specific material pair, let me know and I will update it again. Thank you

I tested the formula and it does not switch. Perhaps raft_base_thickness == 0.5 is sensitive to rounding errors
I also tried: =-0.1 if extruderValue(raft_base_extruder_nr, 'material_type') == 'Nylon12 Carbon Fiber' else -0.05
However, that also did not work :-( [resulted in -0.05 for both PLA and Nylon12-CF)

@wawanbreton just informed me that this is a bug in Cura that they try to resolve before 5.8 beta

resources/quality/ultimaker_method/um_method_labs_um-pla-175_0.2mm.inst.cfg

PP-502

Map mk14_e to LABS extruder. PP-502

PP-502

…te. Removed formulas containing extruder_nr from the def.json files. PP-502

github-actions

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json

…te. Removed formulas containing extruder_nr from the def.json files. PP-502

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

PP-502

wawanbreton and others added 8 commits July 5, 2024 13:18

Change default_value to value

1ed1061

This is necessary because the parent definition of the settings has changed

Applied printer-linter format

a3349ba

Merge branch 'main' into fix-unit-tests-default_startx

36141b4

Merge pull request #19326 from Ultimaker/fix-unit-tests-default_startx

9351096

Change default_value to value

Settings corrections for Method printers

742ed89

PP-502

Applied printer-linter format

76cbf90

Settings corrections for Method printers

4429d0a

PP-502

Applied printer-linter format

94026f4

alanbjorklund requested review from wawanbreton and pkuiper-ultimaker July 10, 2024 21:20

github-actions bot requested changes Jul 10, 2024

View reviewed changes

alanbjorklund and others added 3 commits July 10, 2024 17:42

Update resources/definitions/ultimaker_method_base.def.json

16e24c1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update resources/definitions/ultimaker_method_base.def.json

8a6e2e8

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Applied printer-linter format

5d8dd8f

github-actions bot requested changes Jul 10, 2024

View reviewed changes

resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved

pkuiper-ultimaker reviewed Jul 11, 2024

View reviewed changes

resources/definitions/ultimaker_method.def.json Outdated Show resolved Hide resolved

pkuiper-ultimaker reviewed Jul 11, 2024

View reviewed changes

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg Outdated Show resolved Hide resolved

pkuiper-ultimaker approved these changes Jul 11, 2024

View reviewed changes

wawanbreton changed the base branch from main to 5.8 July 11, 2024 08:01

Merge branch '5.8' into PP-502-Method-Corrections

2fa019f

pkuiper-ultimaker approved these changes Jul 11, 2024

View reviewed changes

wawanbreton approved these changes Jul 11, 2024

View reviewed changes

Fix formula syntax (and simplify it)

6627881

CURA-12009

github-actions bot requested changes Jul 11, 2024

View reviewed changes

resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved

wawanbreton reviewed Jul 11, 2024

View reviewed changes

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved

pkuiper-ultimaker approved these changes Jul 11, 2024

View reviewed changes

nallath requested changes Jul 11, 2024

View reviewed changes

pkuiper-ultimaker added 2 commits July 11, 2024 15:04

Corrected formulas based on comments Jaime.

41b8173

PP-502

Use default_material_print_temperature in formulas for temperature

5aee993

PP-502

pkuiper-ultimaker requested a review from wawanbreton July 11, 2024 13:16

pkuiper-ultimaker requested review from nallath and pkuiper-ultimaker July 11, 2024 13:16

alanbjorklund and others added 2 commits July 11, 2024 09:36

updated based on comments

e5f711b

PP-502

Applied printer-linter format

452e1dd

pkuiper-ultimaker changed the title ~~Pp 502 method corrections~~ [PP-502] Method profile corrections Jul 11, 2024

pkuiper-ultimaker and others added 4 commits July 11, 2024 19:54

Remove experimental tag from ASA and SR30.

adc873e

Map mk14_e to LABS extruder. PP-502

temperature correction in UM PLA 175

f3fbe9a

PP-502

Applied printer-linter format

69e6c4e

Start the Method machines at z=20mm to prevent touching the build pla…

bb04c3b

…te. Removed formulas containing extruder_nr from the def.json files. PP-502

github-actions bot requested changes Jul 15, 2024

View reviewed changes

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved

pkuiper-ultimaker and others added 5 commits July 15, 2024 15:01

Start the Method machines at z=20mm to prevent touching the build pla…

bf594fa

…te. Removed formulas containing extruder_nr from the def.json files. PP-502

Remove unnecessarily overridden setting

b6defce

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Applied printer-linter format

a215ec4

Change support roof distance from 0.25mm to 0.4mm for PVA

1c7057b

PP-502

Merge branch '5.8' into PP-502-Method-Corrections

50ec4d7

wawanbreton merged commit 1c244f0 into 5.8 Jul 16, 2024
2 of 4 checks passed

wawanbreton deleted the PP-502-Method-Corrections branch July 16, 2024 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PP-502] Method profile corrections #19358

[PP-502] Method profile corrections #19358

alanbjorklund commented Jul 10, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

nallath Jul 11, 2024

alanbjorklund Jul 11, 2024

pkuiper-ultimaker Jul 16, 2024 •

edited

Loading

pkuiper-ultimaker Jul 16, 2024

github-actions bot left a comment

[PP-502] Method profile corrections #19358

[PP-502] Method profile corrections #19358

Conversation

alanbjorklund commented Jul 10, 2024

Description

Type of change

How Has This Been Tested?

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

nallath Jul 11, 2024

Choose a reason for hiding this comment

alanbjorklund Jul 11, 2024

Choose a reason for hiding this comment

pkuiper-ultimaker Jul 16, 2024 • edited Loading

Choose a reason for hiding this comment

pkuiper-ultimaker Jul 16, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

pkuiper-ultimaker Jul 16, 2024 •

edited

Loading