[CURA-12050] Start using the 'force_depends_on_settings' property. #19450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful if the relations between settings are cross-extruder, which can happen when a setting that is currently limited to one extruder, depends on another setting (in a value-formula of the like) which is currently limited to _another_ extruder. Note that Irenamed the 'depends_on_settings' to 'force_depends_on_settings' as the former may imply that you should do it for _all_ dependant settings, instead of it being the exception (as we expect that this will occur rarely -- for example in multi-material rafts). CURA-12050
nallath
requested changes
Jul 30, 2024
nallath
reviewed
Jul 30, 2024
Comment on lines
+417
to
+419
| SettingDefinition.addSupportedProperty("force_depends_on_settings", DefinitionPropertyType.Any, default=[], | ||
| read_only=True) | ||
|
|
There was a problem hiding this comment.
Suggested change
| SettingDefinition.addSupportedProperty("force_depends_on_settings", DefinitionPropertyType.Any, default=[], | |
| read_only=True) |
It already lives in uranium, no need to set it again
|
Closing this one as these changes are not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if the relations between settings are cross-extruder, which can happen when a setting that is currently limited to one extruder, depends on another setting (in a value-formula of the like) which is currently limited to another extruder.
Note that I renamed the 'depends_on_settings' to 'force_depends_on_settings' as the former may imply that you should do it for all dependant settings, instead of it being the exception (as we expect that this will occur rarely -- for example in multi-material rafts).
See backend PR: Ultimaker/Uranium#959