Skip to content

Commit

Permalink
Boolean logic error in LayerPlan::computeCombBoundary (#1879)
Browse files Browse the repository at this point in the history
  • Loading branch information
rburema authored Aug 22, 2023
2 parents ddcd384 + 14b3250 commit 8630a4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/LayerPlan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ Polygons LayerPlan::computeCombBoundary(const CombBoundary boundary_type)
{
const SliceLayer& layer = mesh.layers[static_cast<size_t>(layer_nr)];
// don't process infill_mesh or anti_overhang_mesh
if (mesh.settings.get<bool>("infill_mesh") && mesh.settings.get<bool>("anti_overhang_mesh"))
if (mesh.settings.get<bool>("infill_mesh") || mesh.settings.get<bool>("anti_overhang_mesh"))
{
continue;
}
Expand Down

1 comment on commit 8630a4d

@jellespijker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CGcodeAnalyzer'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 8630a4d Previous: 67e49a9 Ratio
All Distances 25 Percentile new_spikes_and_holes_2022.gcode 0.2464974644900017 mm 0.2998833106393281 mm 1.22
Extrusion-Axis new_spikes_and_holes_2022.gcode 0.0027 mm 0.012 mm 4.44
Number Of Temperature Commands cee.gcode 17307 # 22102 # 1.28
Minimum All Distances conical.gcode 0.009848857801798403 mm 0.034525353003270115 mm 3.51
Number Of Temperature Commands support_infill_fail_test.gcode 20934 # 27031 # 1.29
Minimum Line Length squaring.gcode 0.000999999999990564 mm 0.0049999999999954525 mm 5.00
Number Of Temperature Commands squaring.gcode 16138 # 18755 # 1.16
Mean Temperature squaring.gcode 65.5 Celcius 80.7 Celcius 1.23

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.