Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tree support for pointy overhangs: Cradle Generation #1880

Draft
wants to merge 110 commits into
base: main
Choose a base branch
from

Commits on May 7, 2023

  1. Add feature to better support pointy overhangs. Will create a pull re…

    …quest with more information soon.
    ThomasRahm committed May 7, 2023
    Configuration menu
    Copy the full SHA
    108238f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7b6aaa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0997c3b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    12f2572 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    624991d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Fix Cradle Tip generation behaving unexpectedly when support interfac…

    …e is disabled, based on support_tree_roof_cradle setting.
    ThomasRahm committed May 13, 2023
    Configuration menu
    Copy the full SHA
    59531dc View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Improved Tree Support Support Skin Generation and fixed bug causing t…

    …ips to be slightly too large
    ThomasRahm committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dc64f93 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    7e0191e View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Fix Minimum support area not working always when X/Y overrides Z or i…

    …f it is larger than the (hardcoded) minimum fake roof area when roof is disabled
    ThomasRahm committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    810d6ea View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fix branches being wrongly regarded as an error (and removed because …

    …of that) sometimes when the influence area becomes very small, caused by a very small hole in the avoidance.
    ThomasRahm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2538d86 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Merge remote-tracking branch 'upstream/5.6' into tree_support_2

    # Conflicts:
    #	include/SupportInfillPart.h
    #	include/TreeSupportTipGenerator.h
    #	include/TreeSupportUtils.h
    #	src/FffGcodeWriter.cpp
    #	src/SupportInfillPart.cpp
    #	src/TreeModelVolumes.cpp
    #	src/TreeSupport.cpp
    #	src/TreeSupportTipGenerator.cpp
    ThomasRahm committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0d0c841 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3ff9f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Change the way settings are retrieved to enable using a fake plugin t…

    …o supply the UI with the settings
    ThomasRahm committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e0e19ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a7f9c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Update Conan and GitHub workflows

    Implemented significant changes to the Conan file and GitHub workflow
    files in order to increase stability and maintainability.
    The Conan file now fetches versions and requirements from a new data
     source, while unnecessary or redundant code in the workflow files has
     been removed or simplified. This ensures smoother implementation and
     easier troubleshooting for future needs.
    
     Contributes to CURA-11440
    jellespijker committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c216424 View commit details
    Browse the repository at this point in the history
  2. Revert update of fmt and spdlog

    Contributes to CURA-11440
    jellespijker committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b7d7316 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Configuration menu
    Copy the full SHA
    dffcecf View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Fix cradle xy distance

    ThomasRahm committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8cefce5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    36db8a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2023

  1. Merge branch '5.6' into tree_support_2

    # Conflicts:
    #	include/sliceDataStorage.h
    #	src/TreeSupportTipGenerator.cpp
    #	src/sliceDataStorage.cpp
    ThomasRahm committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    c9cda5a View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. More cradle fixes

    ThomasRahm committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    b16c159 View commit details
    Browse the repository at this point in the history
  2. Some fixes to support skin

    ThomasRahm committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    1ae92f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. Configuration menu
    Copy the full SHA
    9e61337 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2024

  1. Configuration menu
    Copy the full SHA
    81eff9e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Configuration menu
    Copy the full SHA
    d357561 View commit details
    Browse the repository at this point in the history
  2. Changed support skin pattern to ZigZag and reduced support skin wall …

    …line count by one to improve strength of support skin.
    ThomasRahm committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    b25a88e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    c983b58 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Cradle refactoring

    ThomasRahm committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    5867e20 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Cradle fixes

    ThomasRahm committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7eb33bb View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Work im progress refactoring to enable removing cradle-lines while th…

    …e tree pathing is calculated.
    ThomasRahm committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    91f6fd5 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    4787452 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a533391 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    39d2a91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20f2755 View commit details
    Browse the repository at this point in the history
  3. Prevent potential issues with applying anti preferred areas to cause …

    …influence areas to become invalid when collision radius != radius
    ThomasRahm committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0cfba23 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. More cradle fixes.

    ThomasRahm committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3d84b94 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Made center of the cradle move slightly with the object it supports

    Also removed code generating additional centers for long pointy overhangs for now.
    ThomasRahm committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    302657c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Configuration menu
    Copy the full SHA
    f275c9c View commit details
    Browse the repository at this point in the history
  2. More cradle fixes

    ThomasRahm committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    64f8ef7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f4a602 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    82835b4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ccf229b View commit details
    Browse the repository at this point in the history
  6. More cradle fixes

    ThomasRahm committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    ea35c28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e2a2833 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    79c7e36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cbf074 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/5.7' into tree_support_2

    # Conflicts:
    #	.github/workflows/benchmark.yml
    #	.github/workflows/conan-package.yml
    #	.github/workflows/gcodeanalyzer.yml
    #	.github/workflows/unit-test-post.yml
    #	.github/workflows/unit-test.yml
    #	CMakeLists.txt
    #	conandata.yml
    #	conanfile.py
    #	include/SupportInfillPart.h
    #	include/TreeModelVolumes.h
    #	include/TreeSupportElement.h
    #	include/TreeSupportSettings.h
    #	include/TreeSupportTipGenerator.h
    #	src/SupportInfillPart.cpp
    #	src/TreeModelVolumes.cpp
    #	src/TreeSupport.cpp
    #	src/TreeSupportTipGenerator.cpp
    #	src/sliceDataStorage.cpp
    #	src/utils/polygonUtils.cpp
    ThomasRahm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2a7aefa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6966fa0 View commit details
    Browse the repository at this point in the history
  5. Fix wrong type name.

    ThomasRahm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    aa00d60 View commit details
    Browse the repository at this point in the history
  6. Removed performance optimisation causing cradle line tips of removed …

    …lines to not be removed
    ThomasRahm committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    27dd92c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    f08100f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    d7cb1aa View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    9a95d4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25acb8c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Merge branch 'improved-fractional-tree-support' into tree_support_2

    # Conflicts:
    #	include/TreeSupport.h
    #	include/TreeSupportSettings.h
    #	include/TreeSupportTipGenerator.h
    #	include/sliceDataStorage.h
    #	src/TreeSupport.cpp
    #	src/TreeSupportTipGenerator.cpp
    ThomasRahm committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    01b10c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    74c8bd4 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/5.7' into tree_support_2

    # Conflicts:
    #	include/TreeSupport.h
    #	include/sliceDataStorage.h
    #	src/TreeSupport.cpp
    ThomasRahm committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    75d2dff View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Configuration menu
    Copy the full SHA
    5f57b8e View commit details
    Browse the repository at this point in the history
  2. Fix fractional support bug related to tree support caused by merging …

    …said changes into the cradle branch.
    ThomasRahm committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    9ef6698 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96d023a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. First refactoring to add setting to ensure initial layer diameter can…

    … be reached. Work in Progress.
    ThomasRahm committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    50c57ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9e0bc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    6d44415 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Configuration menu
    Copy the full SHA
    057ed36 View commit details
    Browse the repository at this point in the history
  2. Improve interaction between cradle base and lines if both are roofs a…

    …nd regular roof wall line count is 0. Now the base overwrites lines. Done make fractional roof look better in this case.
    ThomasRahm committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    8f2ccdd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1309df4 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Configuration menu
    Copy the full SHA
    6a2f662 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2214365 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e5d928 View commit details
    Browse the repository at this point in the history
  4. Fix "Removing already placed tip" when a cradle roof base is only val…

    …id on the first layer and can't be supported below. Now it will just be a roof tip instead.
    ThomasRahm committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    872e8e7 View commit details
    Browse the repository at this point in the history
  5. Prevent roof from generating close to the cradle as any overhang ther…

    …e is already supported. This can prevent cradle lines from being removed as it prevents (some) tips to support said roof.
    ThomasRahm committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    879ecb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Fix regressions with fractional tree support. Also ensure fractional …

    …support correctly handles interface priority.
    ThomasRahm committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f5186eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14f8f3d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    73313c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d17b2d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Improved formatting

    ThomasRahm committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5153fe0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e329928 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abcf5ce View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    aed739c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a7db83 View commit details
    Browse the repository at this point in the history
  3. Fix issue causing force initial layer diameter to be always applied f…

    …or tips placed further down because of xy overrides z
    ThomasRahm committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    93f53f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9637267 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    ba8208d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    2cec577 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a79c0de View commit details
    Browse the repository at this point in the history
  3. Fix support of cradle lines by fixing the reduction

     of overshoot of tips below it.
    ThomasRahm committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b07e7fd View commit details
    Browse the repository at this point in the history
  4. Fix cradle roof base z distance if no fractional roof is present and …

    …fix xy distance for missing lines because of cradle z distance.
    ThomasRahm committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9aa2fad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5efba20 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Fix roof generating for areas that are handled by cradle bases or lin…

    …es. Prevents some kind of overlapping roof lines.
    ThomasRahm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fbbf9fa View commit details
    Browse the repository at this point in the history
  2. Ensure that cradle lines can not intersect with already added roof. P…

    …revents overlapping roof lines.
    ThomasRahm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9d1ebf2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60d8b95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d77e87b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ae25532 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fba4d7b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    798ad56 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cc8147b View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    11b4a76 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    6664a4f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    5e03048 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge remote-tracking branch 'refs/remotes/upstream/5.8' into tree_su…

    …pport_2
    
    # Conflicts:
    #	CMakeLists.txt
    #	include/FffGcodeWriter.h
    #	include/SupportInfillPart.h
    #	include/TreeModelVolumes.h
    #	include/TreeSupport.h
    #	include/TreeSupportElement.h
    #	include/TreeSupportTipGenerator.h
    #	include/TreeSupportUtils.h
    #	include/sliceDataStorage.h
    #	include/utils/polygon.h
    #	src/FffGcodeWriter.cpp
    #	src/SkirtBrim.cpp
    #	src/SupportInfillPart.cpp
    #	src/TreeSupport.cpp
    #	src/TreeSupportTipGenerator.cpp
    #	src/bridge.cpp
    #	src/sliceDataStorage.cpp
    #	src/support.cpp
    #	src/utils/polygon.cpp
    #	src/utils/polygonUtils.cpp
    ThomasRahm committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f26a916 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Adapt to new Shape and LinesSets after merge. Also add back all funct…

    …ions that were lost by the merge (because they were in the poylgons class)
    ThomasRahm committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c0e46cb View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    ae63e19 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    4b9a595 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    ad51551 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Add ability to manually place cradles, refactor the way support modif…

    …ier meshes are stored and fix a small bug preventing non drop down support meshes from slicing correctly
    ThomasRahm committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6e73eb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    5a7a068 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    85bca65 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Improve resiliency if TreeModelVolumes is used without precalculating…

    …. Also prevent parallel for from being used in a nested way.
    ThomasRahm committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    06c6488 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    340e70f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Implement functionality to select whether cradle lines should be prin…

    …ted towards the model, or away from it.
    ThomasRahm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d7d1f71 View commit details
    Browse the repository at this point in the history