Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-10829] Option to not use small skin areas on surface #1925

Merged
merged 28 commits into from
Aug 22, 2023

Commits on Aug 8, 2023

  1. Configuration menu
    Copy the full SHA
    2fddaf0 View commit details
    Browse the repository at this point in the history
  2. Add setting to prevent the top layer from doing small-skin behaviour.

    Actually the other way around, so we don't have another negation you have to turn on to turn off (and so the default can be false I suppose). The idea is that recently, a feature was introduced where there should be walls instead of normal skin in small hard to reach places of the model. However, this is to be excluded in most cases for all the top-layer parts exposed to air on the buildplate.
    
    implements CURA-10829
    rburema committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b4d1828 View commit details
    Browse the repository at this point in the history
  3. Applied clang-format.

    rburema authored and github-actions[bot] committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    279d938 View commit details
    Browse the repository at this point in the history
  4. Fix include-issue exposed by auto-formatter.

    done as part of CURA-10829
    rburema committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8677b10 View commit details
    Browse the repository at this point in the history
  5. Applied clang-format.

    rburema authored and github-actions[bot] committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6c375d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    2b2aa3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5460306 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    0bc6953 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ca463b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fca128c View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    4f34f34 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a31cc3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a3e122c View commit details
    Browse the repository at this point in the history
  7. 1 Configuration menu
    Copy the full SHA
    921af0e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6ac1860 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2c64929 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4cebd6d View commit details
    Browse the repository at this point in the history
  11. 1 Configuration menu
    Copy the full SHA
    abbed4c View commit details
    Browse the repository at this point in the history
  12. 1 Configuration menu
    Copy the full SHA
    4ac9c44 View commit details
    Browse the repository at this point in the history
  13. Merge branch 'CURA-10927_fix_numtype_regression_candidate0' into CURA…

    …-10829_dont_expose_small_skin_to_air
    rburema committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    63386af View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'CURA-10670_reenable_small_skin_area' into CURA-10829_do…

    …nt_expose_small_skin_to_air
    rburema committed Aug 12, 2023
    1 Configuration menu
    Copy the full SHA
    a2ed0bc View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    rburema authored and github-actions[bot] committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    ac86c03 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Also possible to exclude bottom from small skin behaviour.

    Small skin areas replace the normal fill pattern and use walls. Previously in this branch, the possibility was added to not do that to areas exposed to air. It turns out this means in general, not just on the buildplate (also, bottoms can happen away from the buildplate as well of course). As such, take skin bottoms into account of when to exclude areas for consideration when 'Small Top/Bottom On Surface' is off.
    
    part of CURA-10829
    rburema committed Aug 15, 2023
    1 Configuration menu
    Copy the full SHA
    f8818e1 View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    rburema authored and github-actions[bot] committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3e8d340 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    28d365a View commit details
    Browse the repository at this point in the history
  4. Correct typo: to -> too.

    Was still left over from the code review for CURA-10670, committed as part of CURA-10829.
    rburema committed Aug 15, 2023
    1 Configuration menu
    Copy the full SHA
    b85dd9f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Inner countour needs to be unioned and re-intersected anyway to fix s…

    …pill.
    
    And the union _with_ prevent_small_exposed_to_air doesn't hurt if the area us 0 anyway.
    
    Done as part of CURA-10829, but fixes a bug found when QA'ing CURA-10670, which was split off and numbered CURA-10945.
    rburema committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5a0ae57 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Update header

    casperlamboo authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    ef687fe View commit details
    Browse the repository at this point in the history