Cura 10811 improve smooth #1928

casperlamboo · 2023-08-09T20:54:06Z

This includes updated fluid motion logic. A new definition of fluid motion is introduced, here a tool-path-part is considered to be fluid if all of the following criterial hold
a) Vectors [A,B] and [C,D] are "long" (settable through settings)
b) Vector [B,C] is "short" (settable through settings)
c) either on the angles between vectors
- [A_,D_] and [B,C] or,
- [A_,B] and [B,C] or,
- [B,C] and [C,D_]
is below a threshold (settable through the settings)

             B--C
            /    \
           A_     D_
          /        \
         /          \
        A            \
                      \
                       D

Unit tests are added, both to show intent of the isSmooth predicate and to test against future regressions.

Cura-10811

This includes updated fluid motion logic. A new definition of fluid motion is introduced, here a tool-path-part is considered to be fluid if all of the following criterial hold a) Vectors [A,B] and [C,D] are "long" (settable through settings) b) Vector [B,C] is "short" (settable through settings) c) either on the angles between vectors - [A_,D_] and BC or, - [A_,B] and BC or, - [B,C] and [C,D_] is below a threshold (settable through the settings) B--C / \ A_ D_ / \ / \ A \ \ D Unit tests are added, both to show intent of the `isSmooth` predicate and to test against future regressions. CURA-10811

github-actions · 2023-08-09T21:03:52Z

Unit Test Results

26 tests 26 ✔️ 18s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 023037a.

♻️ This comment has been updated with latest results.

CURA-10811

…URA-10811-improve-smooth

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/5)

include/utils/actions/smooth.h

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (2/5)

include/utils/actions/smooth.h

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/3)

include/utils/actions/smooth.h

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (2/3)

include/utils/actions/smooth.h

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

include/utils/actions/smooth.h

src/WallToolPaths.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

jellespijker

Need to do a proper review, this is just me checking the workflow automations

jellespijker · 2023-08-10T00:50:00Z

include/utils/actions/smooth.h

    {
-        if (AB_magnitude == 0.0 || BC_magnitude == 0.0)
+        return cosAngle<Point>(A, B, magnitude(A), magnitude(B));


This seems valid please check

jellespijker · 2023-08-10T00:51:26Z

include/utils/actions/smooth.h

+    requires utils::point2d<Vector> || utils::junction<Vector>
+    auto cosAngle(Vector& A, Vector& B, const utils::floating_point auto A_magnitude, const utils::floating_point auto B_magnitude) const noexcept
+    {
+        if (A_magnitude <= FLT_EPSILON || B_magnitude <= FLT_EPSILON)


please use: https://en.cppreference.com/w/cpp/types/numeric_limits/epsilon

jellespijker · 2023-08-10T00:51:38Z

include/utils/actions/smooth.h

+    requires utils::point2d<Vector> || utils::junction<Vector>
+    auto cosAngle(Vector& A, Vector& B, const utils::floating_point auto A_magnitude, const utils::floating_point auto B_magnitude) const noexcept
+    {
+        if (A_magnitude <= FLT_EPSILON || B_magnitude <= FLT_EPSILON)


please use: https://en.cppreference.com/w/cpp/types/numeric_limits/epsilon

jellespijker · 2023-08-10T00:55:11Z

src/WallToolPaths.cpp

@@ -40,8 +46,15 @@ WallToolPaths::WallToolPaths(const Polygons& outline, const coord_t nominal_bead
 {
 }

-WallToolPaths::WallToolPaths(const Polygons& outline, const coord_t bead_width_0, const coord_t bead_width_x,
-                             const size_t inset_count, const coord_t wall_0_inset, const Settings& settings, const int layer_idx, SectionType section_type )
+WallToolPaths::WallToolPaths(


valid, please check

jellespijker · 2023-08-10T00:55:48Z

src/WallToolPaths.cpp

+        bead_width_0,
+        bead_width_x,
+        wall_transition_length,
+        transitioning_angle,


valid please change the float to a double

jellespijker · 2023-08-10T00:57:10Z

src/WallToolPaths.cpp

    return toolpaths;
 }


 void WallToolPaths::stitchToolPaths(std::vector<VariableWidthLines>& toolpaths, const Settings& settings)
 {
-    const coord_t stitch_distance = settings.get<coord_t>("wall_line_width_x") - 1; //In 0-width contours, junctions can cause up to 1-line-width gaps. Don't stitch more than 1 line width.
+    const coord_t stitch_distance
+        = settings.get<coord_t>("wall_line_width_x") - 1; // In 0-width contours, junctions can cause up to 1-line-width gaps. Don't stitch more than 1 line width.

    for (unsigned int wall_idx = 0; wall_idx < toolpaths.size(); wall_idx++)


valid please change in IDE since this also requires changes in the loop

CURA-10811

It was changing the wrong points CURA-10811

CURA-10811

…URA-10811-improve-smooth

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/4)

include/utils/actions/smooth.h

github-actions · 2023-08-10T10:22:46Z

include/utils/actions/smooth.h

-            const auto [AB_magnitude, BC_magnitude, CD_magnitude] = computeMagnitudes(A, B, C, D);
-            if (! isWithinAllowedDeviations(A, B, C, D, fluid_angle, max_resolution, AB_magnitude, BC_magnitude, CD_magnitude))
+            const auto fluid_motion_shift_distance3 = 3 * fluid_motion_shift_distance;
+            if (dist(*A, *B) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3)


⚠️ readability-identifier-naming ⚠️
invalid case style for variable A

Suggested change

if (dist(*A, *B) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3)

if (dist(*a, *B) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3) {

include/utils/actions/smooth.h

github-actions · 2023-08-10T10:22:46Z

include/utils/actions/smooth.h

-            const auto [AB_magnitude, BC_magnitude, CD_magnitude] = computeMagnitudes(A, B, C, D);
-            if (! isWithinAllowedDeviations(A, B, C, D, fluid_angle, max_resolution, AB_magnitude, BC_magnitude, CD_magnitude))
+            const auto fluid_motion_shift_distance3 = 3 * fluid_motion_shift_distance;
+            if (dist(*A, *B) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3)


⚠️ readability-identifier-naming ⚠️
invalid case style for variable B

Suggested change

if (dist(*A, *B) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3)

if (dist(*A, *b) < fluid_motion_shift_distance3 || dist(*B, *C) > fluid_motion_small_distance || dist(*C, *D) < fluid_motion_shift_distance3) {

github-actions · 2023-08-10T10:22:49Z

include/utils/actions/smooth.h

+    template<class Point>
+    requires utils::point2d<Point> || utils::junction<Point>
+    auto cosAngle(Point& A, Point& B, Point& C) const noexcept
+    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

{

return cosAngle(A, B, c, dist(A, B), dist(B, C));

github-actions · 2023-08-10T10:22:50Z

include/utils/actions/smooth.h

+    template<class Point>
+    requires utils::point2d<Point> || utils::junction<Point>
+    auto cosAngle(Point& A, Point& B, Point& C) const noexcept
+    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

{

return cosAngle(A, B, C, dist(A, B), dist(B, c));

github-actions · 2023-08-10T10:22:50Z

include/utils/actions/smooth.h

+    {
+        return cosAngle(A, B, C, dist(A, B), dist(B, C));
+    }
+
    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter A

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& a, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions · 2023-08-10T10:22:50Z

include/utils/actions/smooth.h

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>
-    constexpr auto computeMagnitudes(Point* A, Point* B, Point* C, Point* D) const noexcept
+    auto cosAngle(Point& A, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter A

Suggested change

{

return cosAngle(a, B, B, C, AB_magnitude, BC_magnitude);

github-actions · 2023-08-10T10:22:50Z

include/utils/actions/smooth.h

+    {
+        return cosAngle(A, B, C, dist(A, B), dist(B, C));
+    }
+
    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter B

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& A, Point& b, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (2/4)

github-actions · 2023-08-10T10:23:08Z

include/utils/actions/smooth.h

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>
-    constexpr auto computeMagnitudes(Point* A, Point* B, Point* C, Point* D) const noexcept
+    auto cosAngle(Point& A, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter B

Suggested change

{

return cosAngle(A, b, B, C, AB_magnitude, BC_magnitude);

github-actions · 2023-08-10T10:23:08Z

include/utils/actions/smooth.h

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>
-    constexpr auto computeMagnitudes(Point* A, Point* B, Point* C, Point* D) const noexcept
+    auto cosAngle(Point& A, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter B

Suggested change

{

return cosAngle(A, B, b, C, AB_magnitude, BC_magnitude);

github-actions · 2023-08-10T10:23:08Z

include/utils/actions/smooth.h

+    {
+        return cosAngle(A, B, C, dist(A, B), dist(B, C));
+    }
+
    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& A, Point& B, Point& c, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions · 2023-08-10T10:23:08Z

include/utils/actions/smooth.h

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>
-    constexpr auto computeMagnitudes(Point* A, Point* B, Point* C, Point* D) const noexcept
+    auto cosAngle(Point& A, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

{

return cosAngle(A, B, B, c, AB_magnitude, BC_magnitude);

github-actions · 2023-08-10T10:23:08Z

include/utils/actions/smooth.h

+    {
+        return cosAngle(A, B, C, dist(A, B), dist(B, C));
+    }
+
    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter AB_magnitude

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& A, Point& B, Point& C, const utils::floating_point auto ab_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions · 2023-08-10T10:23:11Z

include/utils/actions/smooth.h

    }

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>
-    constexpr auto cosAngle(Point* A, Point* B, Point* C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
+    auto cosAngle(Point& A, Point& B, Point& C, Point& D, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept
    {


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter B

Suggested change

{

Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(b) - std::get<"Y">(A) };

github-actions · 2023-08-10T10:23:12Z

include/utils/actions/smooth.h

+    requires utils::point2d<Point> || utils::junction<Point>
+    auto cosAngle(Point& A, Point& B, Point& C, Point& D) const noexcept
+    {
+        return cosAngle(A, B, C, D, dist(A, B), dist(C, D));
    }

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& A, Point& B, Point& c, Point& D, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions · 2023-08-10T10:23:12Z

include/utils/actions/smooth.h

    {
-        if (AB_magnitude == 0.0 || BC_magnitude == 0.0)
+        Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(B) - std::get<"Y">(A) };


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(B) - std::get<"Y">(A) };

Point VectorB = { std::get<"X">(D) - std::get<"X">(c), std::get<"Y">(D) - std::get<"Y">(C) };

github-actions · 2023-08-10T10:23:12Z

include/utils/actions/smooth.h

    {
-        if (AB_magnitude == 0.0 || BC_magnitude == 0.0)
+        Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(B) - std::get<"Y">(A) };


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter C

Suggested change

Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(B) - std::get<"Y">(A) };

Point VectorB = { std::get<"X">(D) - std::get<"X">(C), std::get<"Y">(D) - std::get<"Y">(c) };

github-actions · 2023-08-10T10:23:12Z

include/utils/actions/smooth.h

+    requires utils::point2d<Point> || utils::junction<Point>
+    auto cosAngle(Point& A, Point& B, Point& C, Point& D) const noexcept
+    {
+        return cosAngle(A, B, C, D, dist(A, B), dist(C, D));
    }

    template<class Point>
    requires utils::point2d<Point> || utils::junction<Point>


⚠️ readability-identifier-naming ⚠️
invalid case style for parameter D

Suggested change

requires utils::point2d<Point> || utils::junction<Point>

auto cosAngle(Point& A, Point& B, Point& C, Point& d, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

github-actions · 2023-08-10T10:30:34Z

include/utils/actions/smooth.h

+            const auto cos_fluid_motion_angle = std::cos(fluid_motion_angle);
+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable A

Suggested change

*B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);

*B = shiftPointTowards(*B, *a, fluid_motion_shift_distance);

github-actions · 2023-08-10T10:30:34Z

include/utils/actions/smooth.h

+            const auto cos_fluid_motion_angle = std::cos(fluid_motion_angle);
+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable B

Suggested change

*B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);

*b = shiftPointTowards(*B, *A, fluid_motion_shift_distance);

github-actions · 2023-08-10T10:30:34Z

include/utils/actions/smooth.h

+            const auto cos_fluid_motion_angle = std::cos(fluid_motion_angle);
+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable B

Suggested change

*B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);

*B = shiftPointTowards(*b, *A, fluid_motion_shift_distance);

github-actions · 2023-08-10T10:30:34Z

include/utils/actions/smooth.h

+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);
+                *C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable C

Suggested change

*C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);

*c = shiftPointTowards(*C, *D, fluid_motion_shift_distance);

github-actions · 2023-08-10T10:30:34Z

include/utils/actions/smooth.h

+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);
+                *C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable C

Suggested change

*C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);

*C = shiftPointTowards(*c, *D, fluid_motion_shift_distance);

github-actions · 2023-08-10T10:30:35Z

include/utils/actions/smooth.h

+            if (! isSmooth(*A, *B, *C, *D, cos_fluid_motion_angle))
+            {
+                *B = shiftPointTowards(*B, *A, fluid_motion_shift_distance);
+                *C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);


⚠️ readability-identifier-naming ⚠️
invalid case style for variable D

Suggested change

*C = shiftPointTowards(*C, *D, fluid_motion_shift_distance);

*C = shiftPointTowards(*C, *d, fluid_motion_shift_distance);

CURA-10811

Epsilon is a function aparently and not a constant CURA-10811

Used snake case variable names Use pre-computed dist values CURA-10811

jellespijker · 2023-08-10T13:44:40Z

@casperlamboo might be best if you close this PR and open a new one. The Workflow should be disabled now

CURA-10811

casperlamboo and others added 2 commits August 9, 2023 22:51

Applied clang-format.

7ddb9f3

casperlamboo and others added 7 commits August 9, 2023 23:08

Fix unit tests

d33726b

CURA-10811

Merge remote-tracking branch 'origin/CURA-10811-improve-smooth' into C…

8a99f89

…URA-10811-improve-smooth

Merge branch 'main' into CURA-10811-improve-smooth

62944fa

Merge branch 'main' into CURA-10811-improve-smooth

1b1f702

Merge branch 'main' into CURA-10811-improve-smooth

d51af12

Merge branch 'main' into CURA-10811-improve-smooth

9df4000

Merge branch 'main' into CURA-10811-improve-smooth

0ad9132

github-actions bot requested changes Aug 10, 2023

View reviewed changes

jellespijker and others added 2 commits August 10, 2023 02:42

Merge branch 'main' into CURA-10811-improve-smooth

374eee2

Apply suggestions from code review

c8622c0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

jellespijker requested changes Aug 10, 2023

View reviewed changes

jellespijker and others added 12 commits August 10, 2023 03:15

Merge branch 'main' into CURA-10811-improve-smooth

52fa2ff

Merge branch 'main' into CURA-10811-improve-smooth

0a97168

Merge branch 'main' into CURA-10811-improve-smooth

c782f8f

Merge branch 'main' into CURA-10811-improve-smooth

7ce0747

Merge branch 'main' into CURA-10811-improve-smooth

204a730

Merge branch 'main' into CURA-10811-improve-smooth

ec8e5a1

Merge branch 'main' into CURA-10811-improve-smooth

7bace63

Merge branch 'main' into CURA-10811-improve-smooth

47e08d2

Merge branch 'main' into CURA-10811-improve-smooth

6a4a037

Add unit test

c7143be

CURA-10811

Fix bug in smooth

9eba6ad

It was changing the wrong points CURA-10811

Applied clang-format.

df7d1e8

casperlamboo added 2 commits August 10, 2023 12:17

Remove unneeded comments

c884409

CURA-10811

Merge remote-tracking branch 'origin/CURA-10811-improve-smooth' into C…

63c715c

…URA-10811-improve-smooth

github-actions bot requested changes Aug 10, 2023

View reviewed changes

casperlamboo added 2 commits August 10, 2023 13:05

Use limits

7967365

CURA-10811

Merge branch 'main' into CURA-10811-improve-smooth

e634a99

casperlamboo force-pushed the CURA-10811-improve-smooth branch from ec5d22c to e10d0cf Compare August 10, 2023 11:36

Fix builds

456474b

Epsilon is a function aparently and not a constant CURA-10811

casperlamboo force-pushed the CURA-10811-improve-smooth branch from e10d0cf to 456474b Compare August 10, 2023 11:37

jellespijker and others added 3 commits August 10, 2023 13:57

Merge branch 'main' into CURA-10811-improve-smooth

023037a

Apply suggestions from linter and some optimisation

1d71019

Used snake case variable names Use pre-computed dist values CURA-10811

Applied clang-format.

69e57ee

casperlamboo and others added 3 commits August 11, 2023 08:54

Divinde dist in terms of magnitude

dac24bc

CURA-10811

Inline utility functions

a09eee9

CURA-10811

Applied clang-format.

9c24a9f

casperlamboo closed this Aug 11, 2023

casperlamboo deleted the CURA-10811-improve-smooth branch August 11, 2023 07:23

casperlamboo restored the CURA-10811-improve-smooth branch August 11, 2023 07:23

	if (dist(A, B) < fluid_motion_shift_distance3 \|\| dist(B, C) > fluid_motion_small_distance \|\| dist(C, D) < fluid_motion_shift_distance3)
	if (dist(a, B) < fluid_motion_shift_distance3 \|\| dist(B, C) > fluid_motion_small_distance \|\| dist(C, D) < fluid_motion_shift_distance3) {

	requires utils::point2d<Point> \|\| utils::junction<Point>
	auto cosAngle(Point& a, Point& B, Point& C, const utils::floating_point auto AB_magnitude, const utils::floating_point auto BC_magnitude) const noexcept

	{
	Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(b) - std::get<"Y">(A) };

	Point VectorA = { std::get<"X">(B) - std::get<"X">(A), std::get<"Y">(B) - std::get<"Y">(A) };
	Point VectorB = { std::get<"X">(D) - std::get<"X">(c), std::get<"Y">(D) - std::get<"Y">(C) };

	B = shiftPointTowards(B, *A, fluid_motion_shift_distance);
	B = shiftPointTowards(B, *a, fluid_motion_shift_distance);

	C = shiftPointTowards(C, *D, fluid_motion_shift_distance);
	c = shiftPointTowards(C, *D, fluid_motion_shift_distance);

Cura 10811 improve smooth #1928

Cura 10811 improve smooth #1928

Conversation

casperlamboo commented Aug 9, 2023 • edited Loading

github-actions bot commented Aug 9, 2023 • edited Loading

Unit Test Results

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

jellespijker left a comment

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

jellespijker Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

github-actions bot Aug 10, 2023

Choose a reason for hiding this comment

casperlamboo commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023 •

edited

Loading