CURA-12081 Scarf seam #2137
Merged
CURA-12081 Scarf seam #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12081 Less code, less bugs
Most of the tests where going wrong because the z-height introduced for the scarf seam introduced a refactor that used a variable before it had the correct assignment. part of CURA-12081
In the previous spike, the 'travel_to_z' argument was added (at the end), causing the need for previously omitted (default) parameters to be added as well. In this case, 'spiralize' was omitted, causing the FAN_SPEED_DEFAULT (which is an enum set to -1) to be interpreted as a speed_factor instead. part of CURA-12081
The coasting functionality previously relied (partially) on paths being their own 'complete' extrusions, in between wich where (presumably, mostly) travels. So it only coasted on the last path before a travel, and didn't take into account paths that where to short to complete the full coast (it didn't continue on to the next). This commit fixes that partially -- the volume already coasted isn't taken into account yet, but otherwise it should work as before, but then with the split paths the scarf and accellleration start/end introduced. part of CURA-12081
If, due to the compensation for the paths being split (because of scarf-seams or introduced start/end acceleration-changes), the next path(s) in the 'chunk' are already going to be comletely gone due to coasting, coast less than the 'full' volume for the remainder. part of CURA-12081
7 tasks
nallath
reviewed
Sep 30, 2024
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
This reverts commit 54609c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for a scarf joint seam, and acceleration/deceleration around the seam
Comes with Ultimaker/Cura#19571
Requires Ultimaker/CuraEngine_grpc_definitions#18
CURA-12080
CURA-12081