Fixed crash when applying vesc settings

Ultrawipf · May 31, 2022 · e2ef8b3 · e2ef8b3
1 parent 0117bc6
commit e2ef8b3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,4 +6,7 @@
 - BISS-C encoder support
 - TMC graph follows system style
 - Windows darkmode support
-- Digital and analog readout
+- Digital and analog readout
+
+v1.8.7:
+- Fixed crash when applying vesc settings
diff --git a/main.py b/main.py
@@ -15,7 +15,7 @@
 from dark_palette import PALETTE_DARK
 
 # This GUIs version
-version = "1.8.6"
+version = "1.8.7"
 
 # Minimal supported firmware version. 
 # Major version of firmware must match firmware. Minor versions must be higher or equal

diff --git a/vesc_ui.py b/vesc_ui.py
@@ -31,7 +31,6 @@ def __init__(self, main=None, unique=None):
         #self.checkBox_useEncoder.stateChanged.connect(lambda val : self.sendValue("vesc","useencoder",(0 if val == 0 else 1),instance=self.prefix))
         self.registerCallback("vesc","offbcanid",self.spinBox_OFFB_can_id.setValue,self.prefix,int)
         self.registerCallback("vesc","vesccanid",self.spinBox_VESC_can_Id.setValue,self.prefix,int)
-        #self.registerCallback("vesc","canspd",self.updateCanSpd,self.prefix,int)
         self.registerCallback("vesc","useencoder",self.updateEncoderUI,self.prefix,int)
         self.registerCallback("vesc","offset",self.updateOffset,self.prefix,int)
 
@@ -130,10 +129,8 @@ def updateTimer(self):
         self.sendCommands("vesc",["vescstate","errorflags","voltage","pos","encrate","torque"],self.prefix)
 
     def apply(self):
-        spdPreset = str(self.comboBox_baud.currentIndex()+3) # 3 is lowest preset!
         OpenFFBoardCANId = str(self.spinBox_OFFB_can_id.value())
         VESCCANId = str(self.spinBox_VESC_can_Id.value())
-        #self.sendValue("vesc","canspd",spdPreset,instance=self.prefix)
         self.sendValue("vesc","offbcanid",OpenFFBoardCANId,instance=self.prefix)
         self.sendValue("vesc","vesccanid",VESCCANId,instance=self.prefix)
         self.sendValue("vesc","useencoder",(1 if self.checkBox_useEncoder.isChecked() else 0),instance=self.prefix)