Skip to content

Commit

Permalink
Merge pull request #111 from Umplify/110-remove-the-obsolete-attribute
Browse files Browse the repository at this point in the history
Remove the obsolete attribute and add the readme file to the NuGet package
  • Loading branch information
Arash-Sabet authored Apr 24, 2022
2 parents 50fa3bb + 5291177 commit 1916f6d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ protected override void AddServices(IServiceCollection services, IConfiguration?
protected override ValueTask DisposeAsyncCore()
=> new();

[Obsolete]
protected override IEnumerable<string> GetConfigurationFiles()
{
yield return "appsettings.json";
Expand Down
2 changes: 0 additions & 2 deletions src/Abstracts/TestBedFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ public IServiceProvider GetServiceProvider(ITestOutputHelper testOutputHelper)
=> GetServiceProvider(testOutputHelper).GetService<T>();

protected abstract void AddServices(IServiceCollection services, IConfiguration? configuration);

[Obsolete("This method is deprecated. Please override and use GetTestAppSettings() method instead.", true)]
protected abstract IEnumerable<string> GetConfigurationFiles();
protected abstract IEnumerable<TestAppSettings> GetTestAppSettings();

Expand Down
4 changes: 4 additions & 0 deletions src/Xunit.Microsoft.DependencyInjection.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<PackageReadmeFile>README.md</PackageReadmeFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0"/>
Expand All @@ -14,6 +15,9 @@
<PackageReference Include="xunit.core" Version="2.4.1"/>
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="6.0.1"/>
</ItemGroup>
<ItemGroup>
<None Include="..\README.md" Pack="true" PackagePath="\"/>
</ItemGroup>
<ItemGroup>
<Folder Include="Abstracts\"/>
<Folder Include="TestsOrder\"/>
Expand Down

0 comments on commit 1916f6d

Please sign in to comment.