Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove threddsISO services #424

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Remove threddsISO services #424

merged 7 commits into from
Oct 20, 2023

Conversation

tdrwenski
Copy link
Contributor

@tdrwenski tdrwenski commented Oct 18, 2023 •
edited
Loading

The three ISO services provided by threddsIso create a circular dependency between the TDS and threddsIso. In order to remove this circular dependency and improve the TDS release process, we will remove the ISO services from the TDS war file.

After this PR, the ISO services can still be easily added to a TDS by:
1. Adding the threddsIso artifact tds-plugin-jar-with-dependencies.jar to ${tomcat_home}/webapps/thredds/WEB-INF/lib/
2. enabling ISO services in threddsConfig.xml

This PR:

  • Removes ISO integration tests added in Add threddsIso service tests #420
  • Removes gradle runtime dependency on the threddsIso artifact EDS:tds-plugin
  • Removes threddsIso xsl files (duplicated from threddsIso for some reason)
  • Disables ISO services by default
  • Updates documentation
  • Updates tests that expect a certain number of services (iso services turned off in test config now)

This change is Reviewable

@tdrwenski
Revert creating threddsIso integration tests.
3267c30 
Revert "Update tests to skip comparing dates in output"

This reverts commit 30e22a4.

Revert "Rename test and package"

This reverts commit f54667e.

Revert "Add ncml, iso, and uddc service tests"

This reverts commit 6d0f601.
@tdrwenski
Remove threddsIso xsl files from TDS
4e10983
@tdrwenski
Remove threddsIso from gradle dependencies
23c9fd7
@tdrwenski
Turn off the iso services by default
ef9a282
@tdrwenski
Copy link
Contributor Author

Jenkins tests passing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-tds/15/

@tdrwenski tdrwenski marked this pull request as ready for review October 19, 2023 14:58
haileyajohnson
haileyajohnson approved these changes Oct 20, 2023
View reviewed changes
Copy link

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haileyajohnson haileyajohnson merged commit 7906890 into Unidata:main Oct 20, 2023
9 checks passed
@tdrwenski tdrwenski deleted the remove-iso-services branch October 20, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdrwenski @haileyajohnson