Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ncml in dataset scans opened through ncss #434

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Use ncml in dataset scans opened through ncss #434

merged 6 commits into from
Dec 19, 2023

Conversation

tdrwenski
Copy link
Contributor

@tdrwenski tdrwenski commented Dec 19, 2023 •
edited by lesserwhirls
Loading

Resolves #398.

  • refactor dataset scans with ncml code in openNetcdfFile to helper function
  • Handle dataset scans with ncml in openCoverageDataset (used by NCSS)
  • Small fix for openCoverageDataset code-- don't perform null check when function returns @NonNull
  • Add tests. Update catalog ncml to work for NCSS.

This change is Reviewable

@tdrwenski tdrwenski changed the title Fix ncml dataset scan ncss Use ncml in dataset scans opened through ncss Dec 19, 2023
@tdrwenski tdrwenski mentioned this pull request Dec 19, 2023
Merged
@tdrwenski tdrwenski marked this pull request as ready for review December 19, 2023 21:05
@haileyajohnson haileyajohnson merged commit ed6c5f6 into Unidata:main Dec 19, 2023
9 checks passed
@tdrwenski tdrwenski deleted the fix-ncml-dataset-scan-ncss branch December 19, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datasetScan dataset opened with NCSS does not use NcML
2 participants
@tdrwenski @haileyajohnson