Add apache dependency #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
fix-apache-dependency
branch
from
ad3265f
to
615e04e
Compare
tdrwenski
force-pushed
the
fix-apache-dependency
branch
from
615e04e
to
aaa8567
Compare
haileyajohnson
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDS is not compiling due to missing apache commons-lang 2.0 dependency used in
CatalogViewContextParser. I think what happened is this used to be pulled in by edal-java but they updated to 3.x. So here I update TDS to useorg.apache.commons:commons-lang3but also to explicitly declare it as a dependency.This change is