Fix WMS netcdf file locking issue #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
wms-lock-issue
branch
from
f34ddf6
to
b08b000
Compare
tdrwenski
force-pushed
the
wms-lock-issue
branch
from
b08b000
to
1d1f99a
Compare
haileyajohnson
approved these changes
Feb 13, 2024
tds/src/integrationTests/java/thredds/server/wms/TestUpdateWmsServer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| static int getCacheLoads() { | ||
| return cacheLoads; |
There was a problem hiding this comment.
Are we using the number of cache loads somewhere/need to track it?
There was a problem hiding this comment.
just in the TestWmsCache to test if it reloaded vs reused the cached dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a dataset is opened through WMS, it stays locked in the netcdf file cache. This means the file will never be cleaned up in the cache, since the soft limit does not apply to locked files and the hard limit is set to -1 (no limit) by default.
This PR:
This change is