Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #497

Merged
merged 6 commits into from
May 3, 2024
Merged

Fix warnings #497

merged 6 commits into from
May 3, 2024

Conversation

tdrwenski
Copy link
Contributor

Minor improvements:

  • Fix unchecked compiler warnings by using parametrized containers
  • Use expression lambda instead of statement lambda

@tdrwenski tdrwenski marked this pull request as ready for review May 3, 2024 15:45
DennisHeimbigner
DennisHeimbigner approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine, but be warned. The opendap code is quite old
(pre Java generics), so fixing all of its problems is likely to be a
daunting task.

@haileyajohnson haileyajohnson merged commit cc27701 into Unidata:main May 3, 2024
9 checks passed
@tdrwenski tdrwenski deleted the fix-warnings branch May 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

@DennisHeimbigner DennisHeimbigner DennisHeimbigner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdrwenski @DennisHeimbigner @haileyajohnson