add safecallback #123
Merged
add safecallback #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
previously approved these changes
Jun 18, 2024
contracts/base/ImmutableState.sol
Outdated
| import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol"; | ||
|
|
||
| contract ImmutableState { | ||
| IPoolManager public immutable poolManager; |
There was a problem hiding this comment.
thoughts on naming the variable manager? Feels cleaner when accessing the PM in hooks, its more similar to v4-core (i think), and is more aligned with the modifier / custom error
There was a problem hiding this comment.
I definitely prefer manager I just thought with position manger it would get confusing but tbh im pro manager haha
saucepoint
approved these changes
Jun 18, 2024
Jun1on
pushed a commit
that referenced
this pull request
Jun 18, 2024
* add safecallback * use manager
Jun1on
pushed a commit
that referenced
this pull request
Jul 2, 2024
* add safecallback * use manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes