Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode posm params in calldata #226

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Decode posm params in calldata #226

merged 12 commits into from
Jul 31, 2024

Conversation

hensha256
Copy link
Contributor

@hensha256 hensha256 commented Jul 30, 2024 •
edited
Loading

snreynolds
snreynolds reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look, generally I like. Although I would like @saucepoint to take a look bc he made another comment on a pr about decoding params before we actually do the internal call.

src/PositionManager.sol Outdated Show resolved Hide resolved
@hensha256 hensha256 marked this pull request as ready for review July 31, 2024 09:59
saucepoint
saucepoint reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great as-is. we should probably decide on decoding before vs within the _internalFunctions

really like the tests too

src/libraries/CalldataDecoder.sol Outdated Show resolved Hide resolved
@hensha256 hensha256 merged commit db359ca into main Jul 31, 2024
3 checks passed
@hensha256 hensha256 deleted the posm-decode-calldata branch July 31, 2024 16:47
@snreynolds snreynolds mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snreynolds snreynolds snreynolds left review comments

@saucepoint saucepoint saucepoint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hensha256 @snreynolds @saucepoint