Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take #257

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Take #257

merged 5 commits into from
Aug 3, 2024

Conversation

snreynolds
Copy link
Member

Related Issue

Which issue does this pull request resolve?

Description of changes

@snreynolds snreynolds requested a review from saucepoint August 3, 2024 03:29
src/PositionManager.sol Show resolved Hide resolved
test/position-managers/PositionManager.t.sol Show resolved Hide resolved
test/position-managers/PositionManager.t.sol Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test:

  1. DECREASE
  2. TAKE portion of amount0 to recipient
  3. TAKE portion of amount1 to recipient
  4. TAKE OPEN_DELTAS to owner/msgSender
  5. TAKE OPEN_DELTAS to owner/msgSender

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will create a separate issue for TAKE / TAKE_PAIR to posm)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo yep good test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snreynolds snreynolds mentioned this pull request Aug 3, 2024
@snreynolds snreynolds merged commit 2f15bb2 into main Aug 3, 2024
3 checks passed
@snreynolds snreynolds deleted the take branch August 3, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants