add code hash snap #417
Merged
add code hash snap #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Dec 13, 2024
| function test_posm_initcodeHash() public { | ||
| vm.snapshotValue( | ||
| "position manager initcode hash (without constructor params, as uint256)", | ||
| uint256(keccak256(abi.encodePacked(vm.getCode("PositionManager.sol:PositionManager")))) |
There was a problem hiding this comment.
can you add one for v4router too please?
There was a problem hiding this comment.
i think this function should be in PositionManager.gas.t.sol
its more consistent with how we're doing it in core, and will add the snapshot to PosMGasTest.json (vs. writing yet another artifact file)
saucepoint
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes