Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DrawShape tool not always respecting pivot location #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

modrimkus-unity
Copy link
Contributor

@modrimkus-unity modrimkus-unity commented Nov 20, 2024

Purpose of this PR

PR fixes DrawShapeTool's shift duplication behaviour:

  1. Preview not matching the changes in the original shape when Pivot location is being toggled between previews.
  2. Duplicated shape always having center as it's pivot location - regardless what the original shape had.
  3. Triggering previews between changes to Pivot location sometimes messed up original shape's pivot - it becomes neither pivot nor center.

Before fix:

Screen.Recording.2024-11-20.at.3.46.01.PM.mov

After fix:

Screen.Recording.2024-11-20.at.3.33.30.PM.mov

Links

Jira: https://jira.unity3d.com/browse/PBLD-185

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

@modrimkus-unity modrimkus-unity marked this pull request as ready for review November 20, 2024 20:48
@modrimkus-unity modrimkus-unity changed the title Fix for shift duplicating with Shape creation tool not respecting piv… Fix for DrawShape tool not always respecing pivot location Nov 20, 2024
@modrimkus-unity modrimkus-unity changed the title Fix for DrawShape tool not always respecing pivot location Fix for DrawShape tool not always respecting pivot location Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant