Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs around usage of extracted calibration info #1214

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

cpsiff
Copy link
Contributor

@cpsiff cpsiff commented Dec 18, 2024

Added to / modified documentation to make it more clear how to utilize extracted calibration information, and how to verify that the information is being utilized. Also clarified that the robot must be on to extract calibration info.

I added a description of the parameter-passing method, but not the "create your own description package and use that" method. That seemed a little too in-depth and unnecessary for the getting started documentation, when the parameter method will work for most cases. But if I'm missing something, maybe we want to describe the second method as well.

Related issues: #799

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.78%. Comparing base (1b121b7) to head (cc90e81).
Report is 373 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1214      +/-   ##
========================================
+ Coverage   3.59%   3.78%   +0.19%     
========================================
  Files         13     395     +382     
  Lines        947   43457   +42510     
  Branches     152    6397    +6245     
========================================
+ Hits          34    1645    +1611     
- Misses       843   41669   +40826     
- Partials      70     143      +73     
Flag Coverage Δ
unittests 3.78% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good now, thank you for your contribution @cpsiff

@urfeex urfeex linked an issue Dec 20, 2024 that may be closed by this pull request
@urfeex urfeex merged commit 25bbede into UniversalRobots:main Dec 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tutorial on calibration extraction
2 participants