Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to ros2_controllers JTC API #804

Closed
wants to merge 1 commit into from
Closed

Updated to ros2_controllers JTC API #804

wants to merge 1 commit into from

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Sep 18, 2023 •
edited
Loading

This should fix the current build errors on Iron and Rolling semi binary.

I haven't verified that this is actually the working solution, hence the draft status.

The changes came in in ros-controls/ros2_controllers#609

@mergify mergify bot added the iron label Sep 18, 2023
@fmauch
Copy link
Collaborator Author

fmauch commented Sep 19, 2023

I gave this a manual test and the integration tests seem to be fine, as well, so making this ready for review.

@fmauch fmauch marked this pull request as ready for review September 19, 2023 04:34
@fmauch fmauch requested a review from urmahp September 19, 2023 04:34
@fmauch fmauch removed the iron label Sep 19, 2023
@mergify mergify bot added the iron label Sep 19, 2023
@fmauch fmauch mentioned this pull request Sep 19, 2023
Merged
urmahp
urmahp approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have also verified manually that it works.

@fmauch fmauch mentioned this pull request Sep 20, 2023
Merged
@fmauch
Copy link
Collaborator Author

fmauch commented Sep 20, 2023

I'm closing this in favor of #810 which actually is the better approach, as we are updating the complete API there.

@fmauch fmauch closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmahp urmahp urmahp approved these changes

Assignees
No one assigned
Labels
backport-iron iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmauch @urmahp