Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to enable and disable tool contact #940

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Feb 29, 2024

Also added service to get robot software version.

@URJala
Copy link
Collaborator Author

URJala commented Feb 29, 2024

This requires changes from PR.
This implements the feature requested in #897

@URJala
Copy link
Collaborator Author

URJala commented Apr 11, 2024

Split this pull request into two. This PR now only implements the tool contact functionality and testing of that (Will only work on E-series robots). The get_version service implementation has been moved to PR.

@URJala URJala force-pushed the tool_contact branch 2 times, most recently from 64d0b35 to d825856 Compare July 10, 2024 13:36
@URJala URJala requested a review from fmauch July 10, 2024 13:37
@fmauch
Copy link
Collaborator

fmauch commented Oct 18, 2024

I've tested this today and while it seems to be working well, I think the interface should be improved:

  • The functionality should go to its own controller
  • The controller should be implemented as a chainable controller such that
    • It can be chained after a passthrough trajectory controller (see Forward trajectory controller #944)
    • When chained activating tool contact detection should be done automatically
    • Tool contact should be acknowledged automatically when the trajectory finished
  • When used standalone it should provide an action.

@urfeex urfeex requested review from urfeex and removed request for fmauch November 14, 2024 09:20
@urfeex urfeex linked an issue Nov 14, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for using the Tool contact in the ROS2 driver
2 participants