-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show freshers events on get involved page #375
Conversation
Any reason for OSM rather than google maps out of interest? |
Hi, we probably shouldn't be hardcoding information into the website that will be only useful for a week max, would it not make more sense to add a "public" or similar flag to events on the calendar that already exists on myradio, and then pull the public events to the website? Or atleast make it toggle able in the config so we don't have to push a new release just to disable the Freshers events? |
I'd support not doing that purely for speed as we want this up fast I assume |
Seconded; it makes sense for an embedded map where you don't really care how it looks as long as you can see it, but for something like this I'd say it'd be better to use something more commonly used (and also with directions support, so I can click the link on my phone and get directions to the place). |
I agree hardcoding it like this might bit of a pain when it passes freshers week. |
Ive changed the links to gmaps. |
No description provided.