fix: wrong conditionals in email validation

UoaWDCC · Oct 20, 2024 · 4387903 · 4387903
1 parent 9ca54cc
commit 4387903
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/backend/src/routes/api/user.js b/backend/src/routes/api/user.js
@@ -66,9 +66,8 @@ router.post(
   handle(async (req, res) => {
     const email = req?.body?.email || "";
     if (
-      !(email.split("@").length > 1) &&
-      !allowedDomains.has(email.split("@")[1]) &&
-      !allowedEmails.has(email)
+      email.split("@").length <= 1 ||
+      (!allowedDomains.has(email.split("@")[1]) && !allowedEmails.has(email))
     ) {
       throw new HttpError("Sign in with your UoA account", STATUS.FORBIDDEN);
     }