Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend/componentResolver): correctly resolve speechtext elements #239

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

harbassan
Copy link
Contributor

Describe the issue

A clear and concise description of what the issue is.

Describe the solution

A clear and concise description of what the solution is.

Risk

Potential risks that this PR might brings

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@harbassan harbassan merged commit 8c54b4a into master Sep 17, 2024
7 checks passed
@harbassan harbassan deleted the remove-speech-bubble branch September 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants