Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
A user can sign in to the app using any email account they want, which can potentially lead to confusion when users try to use the application with a non university account.
Describe the solution
Edited the sign-in endpoint at
POST api/user/
to validate the domain against one of:aucklanduni.ac.nz
,auckland.ac.nz
,projects.wdcc.co.nz
.Also changed the way the request is handled on the frontend to make it simpler and actually handle errors sent back by the endpoint properly. For the UI, added user feedback using a toast and added a small subscript underneath the sign-in button on the login page.
Risk
No potential risks.
Definition of Done
Reviewed By
Jin