Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS-55/Domain limitation #245

Merged
merged 4 commits into from
Oct 4, 2024
Merged

VPS-55/Domain limitation #245

merged 4 commits into from
Oct 4, 2024

Conversation

harbassan
Copy link
Contributor

@harbassan harbassan commented Sep 30, 2024

Describe the issue

A user can sign in to the app using any email account they want, which can potentially lead to confusion when users try to use the application with a non university account.

Describe the solution

Edited the sign-in endpoint at POST api/user/ to validate the domain against one of: aucklanduni.ac.nz, auckland.ac.nz, projects.wdcc.co.nz.

Also changed the way the request is handled on the frontend to make it simpler and actually handle errors sent back by the endpoint properly. For the UI, added user feedback using a toast and added a small subscript underneath the sign-in button on the login page.

image
image

Risk

No potential risks.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Jin

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice touch with the toast as well :)
(and the pr description!)

@harbassan harbassan merged commit 2978959 into master Oct 4, 2024
5 checks passed
@harbassan harbassan deleted the domain-limitation branch October 4, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants