Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPS-79/Make scenario desync less frightening #251

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

harbassan
Copy link
Contributor

@harbassan harbassan commented Oct 4, 2024

Describe the issue

The desync page is daunting for users and displays more like an "ERROR DESYNC" rather than a little notification telling them to reset to latest, which would cause confusion

Describe the solution

Changed the desync page from this:

image

to a toast notification that pops out as the page automatically refreshes:

image

which means the user doesn't need to make any actions, but are just gently updated that they were refreshed.

Risk

No risk

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@JordanBlenn JordanBlenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@harbassan harbassan merged commit 10c8c07 into master Oct 4, 2024
5 checks passed
@harbassan harbassan deleted the change-desync-behaviour branch October 4, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants