-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osmox #40
osmox #40
Conversation
Remaining tasks:
|
Do these dependencies need to be added to the poetry lock file? |
Since they're external system deps to python I don't think we're able to install with poetry though we can add this to a requirements section in the docs and link to the osmium docs |
Merging this now with (the output file from pyrosm can be passed directly to osmox (1504c59). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can move these osmox notes to a section in the documentation as part of #63?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add the notes as a subsection under the Installation section of the main README? If that sounds good, do you mind doing it? I think you're better placed to add the notes than I am.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll go ahead and add these notes to the docs as part of #63. I think we can have a section on configuration of the pipeline and we can include a subsection on osmox and mention the default config file JSON (config_osmox.json
) along with the descriptions here.
Related to #19 and #39. We can either: