Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse #1

Merged
merged 22 commits into from
Mar 1, 2024
Merged

Parse #1

merged 22 commits into from
Mar 1, 2024

Conversation

ShNadi
Copy link
Member

@ShNadi ShNadi commented Feb 27, 2024

No description provided.

Copy link
Member

@parisa-zahedi parisa-zahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code. It works well with a random data that I tested. I have only few comments/suggestions

interest/preprocessor/parser.py Outdated Show resolved Hide resolved
interest/preprocessor/parser.py Outdated Show resolved Hide resolved
interest/preprocessor/parser.py Show resolved Hide resolved
interest/preprocessor/parser.py Outdated Show resolved Hide resolved
@ShNadi
Copy link
Member Author

ShNadi commented Mar 1, 2024

Thanks for the code. It works well with a random data that I tested. I have only few comments/suggestions

Thanks for the good points, Parisa. I've made some changes. I think merging the PR is only possible with one reviewer's approval. Please review the changes and approve them, then I'll be able to merge them into the main branch.

@parisa-zahedi parisa-zahedi merged commit 8abfb9b into main Mar 1, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants