add empty correlation skeleton #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-callan
reviewed
Sep 28, 2023
| properties: | ||
| computeConfig: EmptyDataPluginSpec | ||
| config: EmptyDataPluginSpec | ||
| CorrelationAssayMetadataStatsResponse: DifferentialAbundanceStatsResponse |
There was a problem hiding this comment.
do we not know what the response will look like yet?
There was a problem hiding this comment.
we have a plan but since it doesn't matter for the frontend stub i didn't add it yet
Closed
6 tasks
|
@d-callan do you have any concerns that I need to address before merging? The frontend for correlation is now up but without this piece no one can see. |
|
I'd like to know why that new prop is wrong and fix that.. |
|
Do you mean |
d-callan
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves task in VEuPathDB/web-monorepo#512
Adds the skeleton of a correlation bipartite network viz so that the frontend can actually see a visualization. The goal is to really just let the frontend have the endpoint, but as a byproduct we've gone ahead and set up some of the plugin skeleton.