Merge pull request #464 from VEuPathDB/fix-67-volcano-colors

updated volcano colors for accessibility and function
VEuPathDB · Sep 8, 2023 · 349fa3e · 349fa3e
2 parents 6b78ea4 + 947396c
commit 349fa3e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/libs/components/src/stories/plots/VolcanoPlot.stories.tsx b/packages/libs/components/src/stories/plots/VolcanoPlot.stories.tsx
@@ -191,7 +191,7 @@ Simple.args = {
 export const ManyPoints = Template.bind({});
 ManyPoints.args = {
   data: dataSetVolcanoManyPoints,
-  markerBodyOpacity: 0.5,
+  markerBodyOpacity: 0.8,
   log2FoldChangeThreshold: 3,
   significanceThreshold: 0.01,
   independentAxisRange: { min: -9, max: 9 },

diff --git a/packages/libs/components/src/types/plots/addOns.ts b/packages/libs/components/src/types/plots/addOns.ts
@@ -334,9 +334,9 @@ export type SignificanceColors = {
   low: string;
 };
 export const significanceColors: SignificanceColors = {
-  inconclusive: '#B5B8B4',
-  high: '#AC3B4E',
-  low: '#0E8FAB',
+  inconclusive: '#8f8f8f',
+  high: '#a8484b',
+  low: '#007F5C',
 };
 
 /** truncated axis flags */

diff --git a/...s/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx b/...s/eda/src/lib/core/components/visualizations/implementations/VolcanoPlotVisualization.tsx
@@ -57,7 +57,7 @@ import { fixVarIdLabel } from '../../../utils/visualization';
 
 const DEFAULT_SIG_THRESHOLD = 0.05;
 const DEFAULT_FC_THRESHOLD = 2;
-const DEFAULT_MARKER_OPACITY = 0.7;
+const DEFAULT_MARKER_OPACITY = 0.8;
 /**
  * The padding ensures we don't clip off part of the glyphs that represent the most extreme points.
  * We could have also used d3.scale.nice but then we dont have precise control of where the extremes