Merge pull request #429 from VEuPathDB/bubble-legend-rounding-fix

Change rounding algorithm in bubble size legend
VEuPathDB · Aug 25, 2023 · c1a52d0 · c1a52d0
2 parents 1d13ea4 + 73ee18a
commit c1a52d0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/libs/components/src/components/plotControls/PlotBubbleLegend.tsx b/packages/libs/components/src/components/plotControls/PlotBubbleLegend.tsx
@@ -30,11 +30,13 @@ export default function PlotBubbleLegend({
     // The largest circle's value will be the first number that's larger than
     // legendMax and has only one significant digit. Each smaller circle will
     // be half the size of the last (rounded and >= 1)
-    const legendMaxLog10 = Math.floor(Math.log10(legendMax));
+    const roundedOneSigFig = Number(legendMax.toPrecision(1));
     const largestCircleValue =
       legendMax <= 10
         ? legendMax
-        : (Number(legendMax.toPrecision(1)[0]) + 1) * 10 ** legendMaxLog10;
+        : roundedOneSigFig < legendMax
+        ? roundedOneSigFig + 10 ** Math.floor(Math.log10(legendMax)) // effectively rounding up
+        : roundedOneSigFig; // no need to adjust - already rounded up
     const circleValues = _.uniq(
       range(numCircles)
         .map((i) => Math.round(largestCircleValue / 2 ** i))