Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move record page perisistence to wdk-client package #1270

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Nov 12, 2024

This PR moves the logic for persisting the state of a record page from genomics-site to wdk-client.

The state that gets persisted includes:

  1. Page sections that are expanded.
  2. Table rows that are expanded.
  3. If navigation panel is expanded.

Changes include:

  1. Moving persistence code to wdk-client.
  2. Default navigation panel collapsed based on number of top-level categories
  3. Add a method to RecordController component that can be overridden, to determine the default expanded sections.

I've tested this both with main and with orthogroup-tree-table, and all works well.

We may want to consider also persist the table settings: sorting, search filter, and filter columns.

@dmfalke dmfalke requested a review from bobular November 13, 2024 15:29
@dmfalke dmfalke marked this pull request as ready for review November 13, 2024 15:29
Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see where most of the code has moved from/to and the new default section method. Tested in ortho-site and genomics-site and all looks good. Deleted local storage and gene model section is open by default. :-)

@dmfalke dmfalke merged commit aff9a57 into main Nov 20, 2024
1 check passed
@dmfalke dmfalke deleted the wdk-record-page-perisistence branch November 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants