Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard a11y improvements #1274

Merged
merged 13 commits into from
Nov 15, 2024
Merged

Keyboard a11y improvements #1274

merged 13 commits into from
Nov 15, 2024

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Nov 14, 2024

This PR addresses some issues with keyboard accessibility:

  • General: Enable focus ring.
  • PopoverButton: Restore focus to button when menu is closed.
  • SwissArmyButton: Do not override outline style by default.
  • CheckboxTree: Retain focus on internal node when toggling expansion state via keyboard.
  • UserMenu (header): Make fully keyboard accessible (previously could not tab into it).
  • Tooltip: Make fully keyboard accessible.
  • Strategy: Make step edit button fully keyboard accessible.
  • Strategy: Improve focus ring style for basket button in results table.
  • Strategy: Make organism filter show/hide button fully keyboard accessible.

@dmfalke dmfalke requested a review from bobular November 14, 2024 21:42
@dmfalke dmfalke requested review from aurreco-uga and removed request for bobular November 15, 2024 15:44
@dmfalke dmfalke merged commit cdbf6f3 into main Nov 15, 2024
1 check passed
@dmfalke dmfalke deleted the keyboard-a11y-improvements branch November 15, 2024 16:42
@dmfalke
Copy link
Member Author

dmfalke commented Nov 15, 2024

After merging this, I realized I should have used :focus-visible, instead of :focus. I will update this in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants