Map type plugin feature #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - Variable renaming - Modifications to finding active menu item and active map type - Extracting some components
* Move active viz to realm of map type config, and clean up some labels and ids.
3 tasks
|
@bobular you won the dice roll for this review! |
|
I've converted this back to a draft, because I don't think it should be merged this close to a release. Also, the UI changes are likely not desired until we have a collections map type implemented. |
Side panel UX improvements
* Remove marker-related props from MapVEuMap * Move onBoundsChange logic to MapVEuMap; clean up SemanticMarkers hooks * Extract getDefaultAxisRange function * Move DraggableLegendPanel to its own module * Move defaultAnimation to its own module * Extract bubble overlay config into its own function * Add MapType plugins * Wire up MapType plugins * Use plugin displayName in menu * Reduce props passed to getData * Checkpoint commit using @tanstack/query * Incorporate additional changes from merge * Checkpoint - Remove `getData` from `MapTypePlugin` interface - Utilize react-query to cache network requests - Move constants from index module, to prevent circular imports * Add TODO * Propagate selected values for marker configuration to overlay config * Remove TODO * Keep previous query data; use isFetching status to show spinners for maker data * Introduce `MapTypeHeaderDetails` to `MapTypePlugin` * Remove unused type * Crudely reimplment "flyToData" * Pass valueSpec to standalone map markers * Remove out of date comments and code * Remove old comments * Move shared interface to shared file * Use destructured variables * bring back old behaviour for now --------- Co-authored-by: Bob <uncoolbob@gmail.com>
bobular
approved these changes
Oct 25, 2023
__REMOVE_BEFORE_MERGING.md
Outdated
| @@ -0,0 +1 @@ | |||
| This branch is the target for work done to address #241 | |||
bobular
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
related to #241
fixes #403
This branch is the target of some PRs related to #241. The changes to merge are primarily concerned with restructuring the left hand menu.
Here is an image of what it looks like now:
Note that merged child PRs (listed below) have been approved. Please look at those individual PRs for details. This PR should be approved when we are ready to merge (due to data availability, etc).
Child PRs