Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import route and construct sharing url #452

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add import route and construct sharing url #452

merged 2 commits into from
Sep 8, 2023

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Aug 28, 2023

Closes #451

@dmfalke dmfalke requested a review from bobular August 28, 2023 14:13
@bobular
Copy link
Member

bobular commented Aug 31, 2023 via email

bobular
bobular approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great - I don't understand the relevance/urgency of the FIXME but have asked in Slack for more background.

@dmfalke
Copy link
Member Author

dmfalke commented Sep 8, 2023

The FIXME is needed for supporting sharing links like https://vectorbase.org/maps/{analysisId}. Doesn't seem urgent for now.

@dmfalke dmfalke merged commit 6b78ea4 into main Sep 8, 2023
1 check passed
@dmfalke dmfalke deleted the map-sharing-url branch September 8, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobular bobular bobular approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map - disable share menu item for initial beta?
2 participants
@dmfalke @bobular