test expandable computation step container #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asizemore
changed the title
|
Closing, but it's here if we ever need it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous UX meetings (long ago now), there was concern about both the number of steps in the mbio apps and also how many parameters we might have filling up too much page space. We're encountering this issue with the diff abund app because of its data-method dependencies and also how the grouping variables work. All works right now but we could improve the flow clarity by offering more steps. But, of course, that takes up more page space.
Rambling aside, this PR tests what it would be like swapping the step container for expandable panel. I do not suggest we keep the blue background, and there are probably more styling things we should consider. But this is much faster than figma-ing a bunch of expandable panels, thanks to some clever developers who made swapping components really nice 🔥
Thoughts welcome!
Screen.Recording.2023-10-03.at.7.08.48.AM.mov