fix initial bubble marker bug

[moontrip]

Hi @dmfalke (and @bobular):

As commented at #597 (comment) about a bug concerning the bubble marker, I tried to find the reason and fix the bug. After delving into the issue, I realized that it was because marker data is prefetched via useQuery while the legendData via useLegendData hook is still being undefined. This leads the bubble markers to be not shown: more specifically all the marker data have 0 diameters & no colors due to undefined bubbleValueToColorMapper & bubbleValueToDiameterMapper functions at legendData. After sleeping on this, I finally found two possible solutions as follows:

a) Based on the pre-existing comment by Dave, "FIXME Don't make dependent on legend data", I tried to move legendData and the relevant parts to use legendData, i.e., finalMarkerData, out of useMarkerData, i.e. move them to the parent where useMarkerData is called, and then adjusted the parent accordingly. Based on my tests, this worked fine.

b) That being said, an idea came to my mind as an alternative solution after a while. So, basically this can also be considered as an issue of not calling useQuery again (refetch) when legendData is ready (not undefined), thus I changed the conditions of "enabled" option used in the useQuery by additionally checking if legendData is undefined. Certainly, this is much simpler solution than a) and I confirmed that this also worked out.

Due to simplicity, I made PR for b). What do you think @dmfalke?

[dmfalke]

Good detective work! I think this is a fine solution. Thanks!

I know this is in draft mode, but I think it's ready to merge.

[moontrip]

@dmfalke 🕵️
Thank you for your review and confirmation! 👍 I will merge this to main after updating this branch with the latest main

[bobular]

Any reason not to close #597, @moontrip?

I'm looking at #603 now but that can be a separate issue!

Edit: thanks for fixing!!

[moontrip]

@bobular No problem! Honestly, I am not quite sure if my fix is the same with your issue, #597, so can you please test it with your working branch?

[bobular]

I guess this fixes the first bug/screenshot in #597 and then I started rambling on about a second bug which I have described in more detail in #603. I'll edit #597 and close it.