OrthoMCL - Custom tree-table for OrthoGroup page #904
Conversation
bobular
changed the title
… the Mesa inline option
…cally fixed-height mode)
…de (basically fixed-height mode)" This reverts commit f215762.
| <div | ||
| style={{ | ||
| flexGrow: 1, | ||
| width: 1 /* arbitrary non-zero width seems necessary for flex */, | ||
| }} | ||
| > | ||
| <Global | ||
| styles={globalStyle` | ||
| .DataTable { | ||
| margin-bottom: 0px !important; | ||
| width: 80%; | ||
| } | ||
| `} | ||
| /> | ||
| <Mesa state={tableState} /> | ||
| </> | ||
| </div> |
There was a problem hiding this comment.
Sorry, I'm just noticing this. I'm not sure we should use Global here, as the style will be reflected on all subsequent pages.
Instead, could you use a css prop on the parent div component (line 96), and target .DataTable in there?
<div
css={{
flexGrow: 1,
width: 1 /* arbitrary non-zero width seems necessary for flex */,
'.DataTable': {
marginBottom: '0px !important',
width: '80%'
}
}}
>
<Mesa state={tableState} />
</div>There was a problem hiding this comment.
Oh yeah, that's much simpler (and no side effects) - done in 5c896a0 - thanks!
There was a problem hiding this comment.
Could we change these identifiers such that they include the "group" prefix? E.g., GroupTreeResponse, groupTreeResponseDecoder, etc?
…ogroup-tree-table__1254-fixes
…ogroup-tree-table__1254-fixes
| className={cancelBtnClassName} | ||
| style={ | ||
| cancelBtnRightMargin ? { right: cancelBtnRightMargin } : undefined | ||
| }, [delayMs, searchTerm, onSearchTermChange]); |
There was a problem hiding this comment.
Not using
delayMs?
We should fix and test this before merging, @dmfalke
…boxList/SelectList generics 1 of 2
…ixes Orthogroup tree table 1254 fixes
|
I am planning to merge this PR. We can make a new issue for any remaining tasks we intend to implement. |
Testing:
There are only a few tree files available on the back end, so only a few orthogroups work. Here's are the valid OGs at the moment:
Run
ortho-sitelocally and access the path/app/record/group/OG6_102443Back end config for
.envisTo do:
From the #1140 branch
UX suggestions