Skip to content

Commit

Permalink
feat: Update Redesign Signature subtitles (MetaMask#27359)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27359?quickstart=1)

## **Related issues**

Fixes: MetaMask#27218

## **Manual testing steps**

Test test-dapp personal sign and typed sign signatures

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="320"
src="https://github.com/user-attachments/assets/13c829bf-0605-42b1-b735-ecb7fde4f7ec">
<img width="320"
src="https://github.com/user-attachments/assets/82895e25-609f-48ab-8512-613f0ee9c6b0">

### **After**

<img width="320"
src="https://github.com/user-attachments/assets/8778eb35-cede-4f87-891f-9c3ea9a03b2b">
<img width="320"
src="https://github.com/user-attachments/assets/727508a8-1819-452d-99b7-f6c768f977f1">

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
digiwand authored Sep 24, 2024
1 parent 63c5da7 commit 81cec52
Show file tree
Hide file tree
Showing 20 changed files with 10 additions and 61 deletions.
3 changes: 0 additions & 3 deletions app/_locales/de/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/el/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/_locales/en/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/en_GB/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/es/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/fr/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/hi/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/id/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/ja/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/ko/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/pt/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/ru/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/tl/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/tr/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/vi/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/_locales/zh_CN/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,7 @@ describe('PersonalSign Confirmation', () => {

expect(getByText('Signature request')).toBeInTheDocument();
expect(
getByText(
'Only confirm this message if you approve the content and trust the requesting site.',
),
getByText('Review request details before you confirm.'),
).toBeInTheDocument();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ describe('ConfirmTitle', () => {

expect(getByText('Signature request')).toBeInTheDocument();
expect(
getByText(
'Only confirm this message if you approve the content and trust the requesting site.',
),
getByText('Review request details before you confirm.'),
).toBeInTheDocument();
});

Expand Down Expand Up @@ -66,9 +64,7 @@ describe('ConfirmTitle', () => {

expect(getByText('Signature request')).toBeInTheDocument();
expect(
getByText(
'Only confirm this message if you approve the content and trust the requesting site.',
),
getByText('Review request details before you confirm.'),
).toBeInTheDocument();
});

Expand Down
4 changes: 2 additions & 2 deletions ui/pages/confirmations/components/confirm/title/title.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ const getDescription = (
if (isSIWESignatureRequest(confirmation as SignatureRequestType)) {
return t('confirmTitleDescSIWESignature');
}
return t('confirmTitleDescSignature');
return t('confirmTitleDescSign');
case TransactionType.signTypedData:
return isPermitSignatureRequest(confirmation as SignatureRequestType)
? t('confirmTitleDescPermitSignature')
: t('confirmTitleDescSignature');
: t('confirmTitleDescSign');
case TransactionType.tokenMethodApprove:
if (isNFT) {
return t('confirmTitleDescApproveTransaction');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ exports[`Confirm matches snapshot for signature - personal sign type 1`] = `
<p
class="mm-box mm-text mm-text--body-md mm-text--text-align-center mm-box--padding-bottom-4 mm-box--color-text-alternative"
>
Only confirm this message if you approve the content and trust the requesting site.
Review request details before you confirm.
</p>
<div
class="mm-box mm-box--margin-bottom-4 mm-box--padding-2 mm-box--background-color-background-default mm-box--rounded-md"
Expand Down Expand Up @@ -2248,7 +2248,7 @@ exports[`Confirm should match snapshot for signature - typed sign - V4 1`] = `
<p
class="mm-box mm-text mm-text--body-md mm-text--text-align-center mm-box--padding-bottom-4 mm-box--color-text-alternative"
>
Only confirm this message if you approve the content and trust the requesting site.
Review request details before you confirm.
</p>
<div
class="mm-box mm-box--margin-bottom-4 mm-box--padding-2 mm-box--background-color-background-default mm-box--rounded-md"
Expand Down Expand Up @@ -3766,7 +3766,7 @@ exports[`Confirm should match snapshot signature - typed sign - order 1`] = `
<p
class="mm-box mm-text mm-text--body-md mm-text--text-align-center mm-box--padding-bottom-4 mm-box--color-text-alternative"
>
Only confirm this message if you approve the content and trust the requesting site.
Review request details before you confirm.
</p>
<div
class="mm-box mm-box--margin-bottom-4 mm-box--padding-2 mm-box--background-color-background-default mm-box--rounded-md"
Expand Down

0 comments on commit 81cec52

Please sign in to comment.