Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CustomSelect,ChipsSelect): disabled with screen readers #6716

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlackySoul
Copy link
Contributor

  • close #

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Изменения

@BlackySoul BlackySoul self-assigned this Mar 18, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner March 18, 2024 12:00
@BlackySoul BlackySoul added the a11y Доступность (цифровая) label Mar 18, 2024
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 18, 2024
@BlackySoul BlackySoul added cmp:custom-select cmp:chips-select and removed patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Mar 18, 2024
@BlackySoul BlackySoul added this to the v6.0.2 milestone Mar 18, 2024
@BlackySoul BlackySoul added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 18, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 355.84 KB (-0.15% 🔽)
JS (gzip) 108.58 KB (-0.15% 🔽)
JS (brotli) 89.7 KB (-0.23% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260.94 KB (0%)
CSS (gzip) 34.19 KB (0%)
CSS (brotli) 27.77 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 410702b

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (9a989fa) to head (410702b).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6716      +/-   ##
==========================================
- Coverage   82.35%   82.33%   -0.02%     
==========================================
  Files         335      335              
  Lines       10332    10288      -44     
  Branches     3461     3445      -16     
==========================================
- Hits         8509     8471      -38     
+ Misses       1823     1817       -6     
Flag Coverage Δ
unittests 82.33% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as draft March 18, 2024 12:51
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Mar 26, 2024
@BlackySoul BlackySoul modified the milestones: v6.0.2, v6.0.3 Mar 29, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Apr 5, 2024
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 14, 2024
@BlackySoul BlackySoul added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Apr 19, 2024
@SevereCloud SevereCloud modified the milestones: v6.0.3, v6.1.1 May 15, 2024
@BlackySoul BlackySoul modified the milestones: v6.1.1, v6.1.2 Jun 11, 2024
@BlackySoul BlackySoul removed this from the v6.1.2 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Доступность (цифровая) cmp:chips-select cmp:custom-select no-stale Добавляет PR в исключения для автоматического закрытия patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Status: ⛔️ Blocked
Development

Successfully merging this pull request may close these issues.

3 participants