Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PanelHeader): hide separator with transparent PanelHeader #8006

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • e2e-тесты
  • Дизайн-ревью
  • Release notes

Описание

Сейчас есть проблема, что при отключенном разделителе(delimiter="none"), при float={true} и при прозрачной панели(transparent={true}) все равно отображается разделитель, который наезжает на контент и портит вид.

Изменения

Добавил проверку на отсутствие селектора .trnsp при отрисовке разделителя.

Release notes

Исправления

  • PanelHeader: отключен разделитель при прозрачном PanelHeader и delimiter="none"

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 27, 2024 08:55
Copy link
Contributor

github-actions bot commented Nov 27, 2024

size-limit report 📦

Path Size
JS 385.36 KB (0%)
JS (gzip) 116.81 KB (0%)
JS (brotli) 96.17 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 335.09 KB (+0.04% 🔺)
CSS (gzip) 42.43 KB (+0.04% 🔺)
CSS (brotli) 33.47 KB (+0.15% 🔺)

Copy link

codesandbox-ci bot commented Nov 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 7cb96e4

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (027d01d) to head (7cb96e4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8006      +/-   ##
==========================================
- Coverage   95.47%   95.46%   -0.01%     
==========================================
  Files         380      380              
  Lines       11325    11324       -1     
  Branches     3777     3777              
==========================================
- Hits        10812    10811       -1     
  Misses        513      513              
Flag Coverage Δ
unittests 95.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PanelHeader показывает delimeter всегда
2 participants