Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_polygon_package: normalize fractional points #320

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

hieplpvip
Copy link
Contributor

Description

Type of change: improvement

What

Normalize fractional points like 0.8, 1.2 to integers by multiplying by 1000 and then dividing by GCD.

Why

Polygon allows fractional points, but DMOJ does not.

How Has This Been Tested?

Tested on bedao_m20_e

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

Copy link
Contributor

@leduythuccs leduythuccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leduythuccs leduythuccs merged commit e809bfc into master Aug 25, 2023
6 checks passed
@leduythuccs leduythuccs deleted the hiep/polygon-normalize-points branch August 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants