Don't link delayimp on UWP because it doesn't exist there #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you need to make any other changes in order to build for UWP? I tried building your branch for UWP and it didn't seem to work. |
|
What error did you get when trying to build UWP? |
|
I got the following error: Which can be fixed by removing the |
I checked my copy and found that I also did that. My project builds SteamAudio's dependencies as part of the cmake build tree. Maybe an option could be added to disable adding the |
lakulish
added a commit
that referenced
this pull request
Jul 15, 2024
runtime. Also update dependencies script with new flag for selecting static/dynamic linking to the CRT. See also: #349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayimp.libdoes not exist on UWP, but SteamAudio always tries to link it on Windows platforms. This PR prevents SteamAudio from linkingdelayimp.libon UWP. SteamAudio still works on UWP without it.