-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sale_margin_percentage: make purchase price editable I#26616 #1676
[IMP] sale_margin_percentage: make purchase price editable I#26616 #1676
Conversation
I don't see the cause-effect relation here. |
6681590
to
c3de3df
Compare
It was not ready :c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update PR's description to match commit's description
@@ -7,7 +7,7 @@ class SaleOrderLine(models.Model): | |||
margin_threshold = fields.Float( | |||
default=lambda self: self.env.user.company_id.margin_threshold, help="Limit margin set in sales configuration" | |||
) | |||
purchase_price = fields.Float(readonly=True, help="Price purchase of product") | |||
purchase_price = fields.Float(help="Price purchase of product") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove inheritance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This module was originally created in v11 for a specific customer, and the purchase price needed to be non-editable for some reason. Now the purchase price does not need to be non-editable. If it is needed, it should be managed in the view because the field is natively editable.
c3de3df
to
773ac6e
Compare
This module was originally created in v11 for a specific customer, and
the purchase price needed to be non-editable for some reason. Now the
purchase price does not need to be non-editable. If it is needed, it
should be managed in the view because the field is natively editable.