Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock_manual_transfer: Missing label in routes view #1683

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

TeposteAJ
Copy link
Contributor

@TeposteAJ TeposteAJ commented Aug 29, 2024

The fields for warehouses_selectable and manual_transfers_selectable were placed on a single line. There was no clarity on what they represented, as they were just two checkboxes without the appropriate labels.

Therefore, manual_transfers_selectable was placed on its own line.

Form Routes View.

  • Before development. Without the warehouses checkboxes checked. It doesn't show anything.
    image
  • After development. Without the warehouses & manual_transfers checkboxes checked. There is a single checkbox per line, and each field has its corresponding label, which provides greater clarity.
    image

Form Routes View.

  • Before development. With the checkboxes checked, it shows a selection field.
    image
  • After development. With the checkboxes checked, it shows a selection field for warehouses.
    image

The fields for `warehouses_selectable` and `manual_transfers_selectable`
were placed on a single line. There was no clarity on what they represented,
as they were just two checkboxes without the appropriate labels.

Therefore, `manual_transfers_selectable` was placed on its own line.
Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit description:

  • "Therefore, manual_transfers_selectable was moved to a separate field." → to its own line

@TeposteAJ TeposteAJ force-pushed the 17.0-Fix_MT_Inherited-TeposteAJ branch from 3c9b47b to 27da6ff Compare August 29, 2024 22:47
Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luisg123v luisg123v merged commit efdf453 into Vauxoo:17.0 Aug 29, 2024
2 of 3 checks passed
@luisg123v luisg123v deleted the 17.0-Fix_MT_Inherited-TeposteAJ branch August 29, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants