[FIX] default_warehouse_from_sale_team: prevent Sales Team compute on default journal set i#28375 #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @hugho-ad, Could you review, please? Regards. cc. @desdelinux |
luisg123v
requested changes
Dec 30, 2024
| team = self.env.context.get("salesteam") or self.team_id or self.env.user.sale_team_id | ||
| team = ( | ||
| self.env.context.get("salesteam") | ||
| or (self._cache["team_id"] and self.team_id) |
There was a problem hiding this comment.
If already checking the cache, why do you need to read the current value?
There was a problem hiding this comment.
Because the cached value contains only the ID and not the record.
There was a problem hiding this comment.
Updated to use the convert_to_record method as suggested.
There was a problem hiding this comment.
Thanks a lot! I like the new approach.
Just only one more request:
Since that's not a trivial code, could you add a small comment above the new line (the one with _fields) explaining why?
desdelinux
approved these changes
Jan 2, 2025
CLaurelB
force-pushed
the
17.0-avoid_triggering_team_id_compute-CLaurelB
branch
from
b0fbe23 to
9546b5a
Compare
… default journal set Use the cached value of the Sales Team field to access its value as a record. This avoids computing its value when it has not been computed yet, which could result in setting the wrong Sales Team on an invoice form creation. This issue occurs because the company is not yet set, and its value is required to determine the correct Sales Team [1]. [1]: https://github.com/odoo/odoo/blob/3884a60e/addons/sale/models/account_move.py#L41
CLaurelB
force-pushed
the
17.0-avoid_triggering_team_id_compute-CLaurelB
branch
from
9546b5a to
71da6d8
Compare
luisg123v
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the cached value of the Sales Team field to access its value as a record. This avoids computing its value when it has not been computed yet, which could result in setting the wrong Sales Team on an invoice form creation. This issue occurs because the company is not yet set, and its value is required to determine the correct Sales Team 1.