Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dynamic groups in AzureAD and the VB365 jobs accordingly #183

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

d-works42
Copy link
Contributor

Pull Request Template

By contributing, you agree that your contributions will be licensed under the projects original open source license.

Description

This is an extension of the script VBO-CreateDynamicGroups to create the VB365 jobs accordingly. Also, the dynamic groups membership rules have been extended.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Testet in personal lab and at one customer.

Checklist (check all applicable):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@carceneaux
Copy link
Contributor

Thanks for your contribution, @d-works42!

After skimming the PR, can you please update the README file letting others know which Veeam Backup for Microsoft 365 versions the script was tested against and/or supports.

Here's a sample README you can use as a reference:

https://github.com/VeeamHub/powershell/blob/master/VB365-ExportMailboxToPST/README.md

@carceneaux carceneaux self-requested a review July 5, 2023 16:46
Copy link
Contributor

@carceneaux carceneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct changes and then this PR will be good to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README file letting others know which Veeam Backup for Microsoft 365 versions the script was tested against and/or supports.

Here's a sample README you can use as a reference:

https://github.com/VeeamHub/powershell/blob/master/VB365-ExportMailboxToPST/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow came over this comment, edited now.

added tested version and rewritten to align with the docuemtn standard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants