Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC-32829 / Adds GCP cucumber tests for provisioning #492

Merged
merged 3 commits into from
Jun 4, 2024
Merged

VC-32829 / Adds GCP cucumber tests for provisioning #492

merged 3 commits into from
Jun 4, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

@luispresuelVenafi luispresuelVenafi commented Jun 3, 2024 •
edited
Loading

  • Adds Google Provider basic cucumber test
  • Adds GCM client to delete certificate afterward
  • Removes unused gemfile
  • updates pickup-id validators to proper variable

@luispresuelVenafi luispresuelVenafi force-pushed the VC-32829/cucumber-tests-for-provisioning branch from daa4b2b to a6c362e Compare June 3, 2024 16:35
@luispresuelVenafi luispresuelVenafi force-pushed the VC-32829/cucumber-tests-for-provisioning branch from 4141800 to 23ba91f Compare June 3, 2024 19:59
@luispresuelVenafi luispresuelVenafi changed the title Vc 32829/cucumber tests for provisioning VC-32829 / Adds GCP cucumber tests for provisioning Jun 4, 2024
@luispresuelVenafi luispresuelVenafi merged commit 38f28d3 into master Jun 4, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the VC-32829/cucumber-tests-for-provisioning branch June 4, 2024 17:14
@luispresuelVenafi luispresuelVenafi restored the VC-32829/cucumber-tests-for-provisioning branch June 5, 2024 19:50
@luispresuelVenafi luispresuelVenafi deleted the VC-32829/cucumber-tests-for-provisioning branch June 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoVV EduardoVV EduardoVV approved these changes

@marcos-albornoz marcos-albornoz marcos-albornoz approved these changes

@rvelaVenafi rvelaVenafi rvelaVenafi approved these changes

@JigarAtVenafi JigarAtVenafi Awaiting requested review from JigarAtVenafi

@sbanic-venafi sbanic-venafi Awaiting requested review from sbanic-venafi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luispresuelVenafi @rvelaVenafi @marcos-albornoz @EduardoVV